Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

change 'run test' shortcut to 'enter with shift'

Browse source
This commit is contained in:
jonghoonpark 2024-03-12 22:45:05 +09:00
parent 7ccb006b01
commit 922a6868b5
2 changed files with 3 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/trace-viewer/src/ui/uiModeView.tsx
View file

@ -179,7 +179,7 @@ export const UIModeView: React.FC<{}> = ({
React.useEffect(() => { React.useEffect(() => {
const onShortcutEvent = (e: KeyboardEvent) => { const onShortcutEvent = (e: KeyboardEvent) => {
if (e.code === 'KeyR' && (e.metaKey || e.ctrlKey)){ if (e.key === 'Enter' && e.shiftKey) {
e.preventDefault(); e.preventDefault();
runTests('bounce-if-busy', visibleTestIds); runTests('bounce-if-busy', visibleTestIds);
} else if (e.code === 'KeyS' && (e.metaKey || e.ctrlKey)) { } else if (e.code === 'KeyS' && (e.metaKey || e.ctrlKey)) {

15
tests/playwright-test/ui-mode-test-shortcut.spec.ts
View file

@ -28,24 +28,13 @@ const basicTestTree = {
` `
}; };
test('should run on Meta(command) with R', async ({ runUITest }) => { test('should run on Enter with Shift', async ({ runUITest }) => {
const { page } = await runUITest(basicTestTree); const { page } = await runUITest(basicTestTree);
await expect(page.getByTitle('Run all')).toBeEnabled(); await expect(page.getByTitle('Run all')).toBeEnabled();
await expect(page.getByTitle('Stop')).toBeDisabled(); await expect(page.getByTitle('Stop')).toBeDisabled();
await page.keyboard.press('Meta+r'); await page.keyboard.press('Enter+Shift');
await expect(page.getByTestId('status-line')).toHaveText('Running 1/4 passed (25%)');
});
test('should run on Control with R', async ({ runUITest }) => {
const { page } = await runUITest(basicTestTree);
await expect(page.getByTitle('Run all')).toBeEnabled();
await expect(page.getByTitle('Stop')).toBeDisabled();
await page.keyboard.press('Control+r');
await expect(page.getByTestId('status-line')).toHaveText('Running 1/4 passed (25%)'); await expect(page.getByTestId('status-line')).toHaveText('Running 1/4 passed (25%)');
}); });