Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

unflake

Browse source
This commit is contained in:
Max Schmitt 2024-08-22 00:25:54 +02:00
parent 4252396305
commit 93bdcb9708
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/library/client-certificates.spec.ts
View file

@ -377,7 +377,7 @@ test.describe('browser', () => {
await page.close(); await page.close();
}); });
test('should handle TLS renegotiation with client certificates', async ({ browser, asset }) => { test('should handle TLS renegotiation with client certificates', async ({ browser, asset, browserName, platform }) => {
const server: https.Server = createHttpsServer({ const server: https.Server = createHttpsServer({
key: fs.readFileSync(asset('client-certificates/server/server_key.pem')), key: fs.readFileSync(asset('client-certificates/server/server_key.pem')),
cert: fs.readFileSync(asset('client-certificates/server/server_cert.pem')), cert: fs.readFileSync(asset('client-certificates/server/server_cert.pem')),
@ -390,6 +390,8 @@ test.describe('browser', () => {
}); });
server.on('request', async (req, res) => { server.on('request', async (req, res) => {
if (!req.socket)
return;
const renegotiate = () => new Promise<void>((resolve, reject) => { const renegotiate = () => new Promise<void>((resolve, reject) => {
(req.socket as tls.TLSSocket).renegotiate({ (req.socket as tls.TLSSocket).renegotiate({
requestCert: true, requestCert: true,
@ -409,10 +411,12 @@ test.describe('browser', () => {
'Content-Type': 'text/plain', 'Content-Type': 'text/plain',
'Transfer-Encoding': 'chunked' 'Transfer-Encoding': 'chunked'
}); });
res.flushHeaders();
req.on('data', data => { await new Promise<void>(resolve => req.once('data', data => {
res.write(`server received: ${data.toString()}\n`); res.write(`server received: ${data.toString()}\n`);
}); resolve();
}));
await renegotiate(); await renegotiate();
for (let i = 0; i < 4; i++) { for (let i = 0; i < 4; i++) {
@ -458,12 +462,13 @@ test.describe('browser', () => {
await new Promise<void>(resolve => server.listen(0, 'localhost', resolve)); await new Promise<void>(resolve => server.listen(0, 'localhost', resolve));
const port = (server.address() as import('net').AddressInfo).port; const port = (server.address() as import('net').AddressInfo).port;
const serverUrl = `https://localhost:${port}`; const origin = 'https://' + (browserName === 'webkit' && platform === 'darwin' ? 'local.playwright' : 'localhost');
const serverUrl = `${origin}:${port}`;
const context = await browser.newContext({ const context = await browser.newContext({
ignoreHTTPSErrors: true, ignoreHTTPSErrors: true,
clientCertificates: [{ clientCertificates: [{
origin: `https://localhost:${port}`, origin,
certPath: asset('client-certificates/client/trusted/cert.pem'), certPath: asset('client-certificates/client/trusted/cert.pem'),
keyPath: asset('client-certificates/client/trusted/key.pem'), keyPath: asset('client-certificates/client/trusted/key.pem'),
}], }],