From 9485e62a00a955e0923e734929c4afcf0a2dc509 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Mon, 15 Nov 2021 23:37:39 -0800 Subject: [PATCH] chore(trace-viewer): only show source tab when soureces are includes (#10338) --- packages/playwright-core/src/web/traceViewer/entries.ts | 2 ++ packages/playwright-core/src/web/traceViewer/traceModel.ts | 2 ++ packages/playwright-core/src/web/traceViewer/ui/workbench.tsx | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/web/traceViewer/entries.ts b/packages/playwright-core/src/web/traceViewer/entries.ts index c731e2dd0a..8ab2d61c7f 100644 --- a/packages/playwright-core/src/web/traceViewer/entries.ts +++ b/packages/playwright-core/src/web/traceViewer/entries.ts @@ -30,6 +30,7 @@ export type ContextEntry = { actions: trace.ActionTraceEvent[]; events: trace.ActionTraceEvent[]; objects: { [key: string]: any }; + hasSource: boolean; }; export type PageEntry = { @@ -55,5 +56,6 @@ export function createEmptyContext(): ContextEntry { actions: [], events: [], objects: {}, + hasSource: false }; } diff --git a/packages/playwright-core/src/web/traceViewer/traceModel.ts b/packages/playwright-core/src/web/traceViewer/traceModel.ts index fc5570e952..5142294424 100644 --- a/packages/playwright-core/src/web/traceViewer/traceModel.ts +++ b/packages/playwright-core/src/web/traceViewer/traceModel.ts @@ -48,6 +48,8 @@ export class TraceModel { traceEntry = entry; if (entry.filename.endsWith('.network')) networkEntry = entry; + if (entry.filename.includes('src@')) + this.contextEntry.hasSource = true; this._entries.set(entry.filename, entry); } this._snapshotStorage = new PersistentSnapshotStorage(this._entries); diff --git a/packages/playwright-core/src/web/traceViewer/ui/workbench.tsx b/packages/playwright-core/src/web/traceViewer/ui/workbench.tsx index 31464cacd3..36c89ba8d6 100644 --- a/packages/playwright-core/src/web/traceViewer/ui/workbench.tsx +++ b/packages/playwright-core/src/web/traceViewer/ui/workbench.tsx @@ -124,7 +124,7 @@ export const Workbench: React.FunctionComponent<{ { id: 'network', title: 'Network', count: networkCount, render: () => }, ]; - if (window.location.hostname === 'localhost' || window.location.hostname === '127.0.0.1') + if (contextEntry.hasSource) tabs.push({ id: 'source', title: 'Source', count: 0, render: () => }); return
{ event.preventDefault(); setDragOver(true); }}>