Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: bump extract-zip dependency (#1696)

Browse source 
Fixes #1510
This commit is contained in:
Andrey Lushnikov 2020-04-07 14:56:30 -07:00 committed by GitHub
parent c6f580faf8
commit 949dc7b514
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -44,7 +44,7 @@
"license": "Apache-2.0", "license": "Apache-2.0",
"dependencies": { "dependencies": {
"debug": "^4.1.0", "debug": "^4.1.0",
"extract-zip": "^1.6.6", "extract-zip": "^2.0.0",
"https-proxy-agent": "^3.0.0", "https-proxy-agent": "^3.0.0",
"jpeg-js": "^0.3.6", "jpeg-js": "^0.3.6",
"mime": "^2.4.4", "mime": "^2.4.4",

11
src/server/browserFetcher.ts
View file

@ -145,7 +145,7 @@ export async function downloadBrowser(options: DownloadOptions): Promise<void> {
const zipPath = path.join(os.tmpdir(), `playwright-download-${browser}-${platform}-${revision}.zip`); const zipPath = path.join(os.tmpdir(), `playwright-download-${browser}-${platform}-${revision}.zip`);
try { try {
await downloadFile(url, zipPath, progress); await downloadFile(url, zipPath, progress);
await extractZip(zipPath, downloadPath); await extract(zipPath, {dir: downloadPath});
} finally { } finally {
if (await existsAsync(zipPath)) if (await existsAsync(zipPath))
await unlinkAsync(zipPath); await unlinkAsync(zipPath);
@ -211,15 +211,6 @@ function downloadFile(url: string, destinationPath: string, progressCallback: On
} }
} }
function extractZip(zipPath: string, folderPath: string): Promise<Error | null> {
return new Promise((fulfill, reject) => extract(zipPath, {dir: folderPath}, err => {
if (err)
reject(err);
else
fulfill();
}));
}
function httpRequest(url: string, method: string, response: (r: any) => void) { function httpRequest(url: string, method: string, response: (r: any) => void) {
let options: any = URL.parse(url); let options: any = URL.parse(url);
options.method = method; options.method = method;