Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(aria): escape leading dash in property values (#34227)

Browse source
This commit is contained in:
Pavel Feldman 2025-01-07 11:14:45 -08:00 committed by GitHub
parent d2af88c1fe
commit 9514f0fb9d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright-core/src/server/injected/yaml.ts
View file

@ -58,8 +58,8 @@ function yamlStringNeedsQuotes(str: string): boolean {
if (/[\x00-\x08\x0b\x0c\x0e-\x1f\x7f-\x9f]/.test(str)) if (/[\x00-\x08\x0b\x0c\x0e-\x1f\x7f-\x9f]/.test(str))
return true; return true;
// Strings starting with '-' followed by a space need quotes // Strings starting with '-' need quotes
if (/^-\s/.test(str)) if (/^-/.test(str))
return true; return true;
// Strings containing ':' or '\n' followed by a space or at the end need quotes // Strings containing ':' or '\n' followed by a space or at the end need quotes

3
tests/page/page-aria-snapshot.spec.ts
View file

@ -555,6 +555,7 @@ it('should escape special yaml values', async ({ page }) => {
<a href="#">null</a>NULL <a href="#">null</a>NULL
<a href="#">123</a>123 <a href="#">123</a>123
<a href="#">-1.2</a>-1.2 <a href="#">-1.2</a>-1.2
<a href="#">-</a>-
<input type=text value="555"> <input type=text value="555">
`); `);
@ -573,6 +574,8 @@ it('should escape special yaml values', async ({ page }) => {
- text: "123" - text: "123"
- link "-1.2" - link "-1.2"
- text: "-1.2" - text: "-1.2"
- link "-"
- text: "-"
- textbox: "555" - textbox: "555"
`); `);
}); });