From 969e6f2ada09122f43fe832ad83c5898f92afed7 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 4 May 2022 16:38:25 -0700 Subject: [PATCH] feat(webkit): roll to r1637 (#13916) --- packages/playwright-core/browsers.json | 2 +- tests/page/page-route.spec.ts | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index f51650845c..97ea878860 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -28,7 +28,7 @@ }, { "name": "webkit", - "revision": "1632", + "revision": "1637", "installByDefault": true, "revisionOverrides": { "mac10.14": "1446", diff --git a/tests/page/page-route.spec.ts b/tests/page/page-route.spec.ts index 06804b2715..512ae9730f 100644 --- a/tests/page/page-route.spec.ts +++ b/tests/page/page-route.spec.ts @@ -15,6 +15,7 @@ * limitations under the License. */ +import os from 'os'; import type { Route } from 'playwright-core'; import { test as it, expect } from './pageTest'; @@ -241,14 +242,15 @@ it('should be abortable', async ({ page, server }) => { expect(failed).toBe(true); }); -it('should be abortable with custom error codes', async ({ page, server, browserName }) => { +it('should be abortable with custom error codes', async ({ page, server, browserName, isMac }) => { await page.route('**/*', route => route.abort('internetdisconnected')); let failedRequest = null; page.on('requestfailed', request => failedRequest = request); await page.goto(server.EMPTY_PAGE).catch(e => {}); expect(failedRequest).toBeTruthy(); + const isFrozenWebKit = isMac && parseInt(os.release(), 10) < 20; if (browserName === 'webkit') - expect(failedRequest.failure().errorText).toBe('Request intercepted'); + expect(failedRequest.failure().errorText).toBe(isFrozenWebKit ? 'Request intercepted' : 'Blocked by Web Inspector'); else if (browserName === 'firefox') expect(failedRequest.failure().errorText).toBe('NS_ERROR_OFFLINE'); else @@ -267,13 +269,14 @@ it('should send referer', async ({ page, server }) => { expect(request.headers['referer']).toBe('http://google.com/'); }); -it('should fail navigation when aborting main resource', async ({ page, server, browserName }) => { +it('should fail navigation when aborting main resource', async ({ page, server, browserName, isMac }) => { await page.route('**/*', route => route.abort()); let error = null; await page.goto(server.EMPTY_PAGE).catch(e => error = e); expect(error).toBeTruthy(); + const isFrozenWebKit = isMac && parseInt(os.release(), 10) < 20; if (browserName === 'webkit') - expect(error.message).toContain('Request intercepted'); + expect(error.message).toContain(isFrozenWebKit ? 'Request intercepted' : 'Blocked by Web Inspector'); else if (browserName === 'firefox') expect(error.message).toContain('NS_ERROR_FAILURE'); else