From 9795a4ba60479fc75de7187e681ba9e90891bb54 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Wed, 3 Aug 2022 10:51:45 +0200 Subject: [PATCH] test: mark again some Android tests as fixme --- tests/page/frame-goto.spec.ts | 4 +++- tests/page/locator-frame.spec.ts | 4 +++- tests/page/page-click.spec.ts | 3 ++- tests/page/page-goto.spec.ts | 3 ++- tests/page/page-request-fulfill.spec.ts | 7 ++++--- 5 files changed, 14 insertions(+), 7 deletions(-) diff --git a/tests/page/frame-goto.spec.ts b/tests/page/frame-goto.spec.ts index 80cbf765b2..cb9620c6e6 100644 --- a/tests/page/frame-goto.spec.ts +++ b/tests/page/frame-goto.spec.ts @@ -40,7 +40,9 @@ it('should reject when frame detaches', async ({ page, server }) => { expect(error.message).toContain('frame was detached'); }); -it('should continue after client redirect', async ({ page, server }) => { +it('should continue after client redirect', async ({ page, server, isAndroid }) => { + it.fixme(isAndroid); + server.setRoute('/frames/script.js', () => {}); const url = server.PREFIX + '/frames/child-redirect.html'; const error = await page.goto(url, { timeout: 5000, waitUntil: 'networkidle' }).catch(e => e); diff --git a/tests/page/locator-frame.spec.ts b/tests/page/locator-frame.spec.ts index cc40421168..83b8289529 100644 --- a/tests/page/locator-frame.spec.ts +++ b/tests/page/locator-frame.spec.ts @@ -106,7 +106,9 @@ it('should wait for frame 2', async ({ page, server }) => { await page.frameLocator('iframe').locator('button').click(); }); -it('should wait for frame to go', async ({ page, server }) => { +it('should wait for frame to go', async ({ page, server, isAndroid }) => { + it.fixme(isAndroid); + await routeIframe(page); await page.goto(server.EMPTY_PAGE); setTimeout(() => page.$eval('iframe', e => e.remove()).catch(() => {}), 300); diff --git a/tests/page/page-click.spec.ts b/tests/page/page-click.spec.ts index d665fd9180..1af305d49c 100644 --- a/tests/page/page-click.spec.ts +++ b/tests/page/page-click.spec.ts @@ -838,8 +838,9 @@ it('should not throw protocol error when navigating during the click', async ({ expect(await page.evaluate('result')).toBe('Clicked'); }); -it('should retry when navigating during the click', async ({ page, server, mode }) => { +it('should retry when navigating during the click', async ({ page, server, mode, isAndroid }) => { it.skip(mode !== 'default'); + it.fixme(isAndroid); await page.goto(server.PREFIX + '/input/button.html'); let firstTime = true; diff --git a/tests/page/page-goto.spec.ts b/tests/page/page-goto.spec.ts index ddc4cdc740..3dd5e08bd6 100644 --- a/tests/page/page-goto.spec.ts +++ b/tests/page/page-goto.spec.ts @@ -634,8 +634,9 @@ it('should properly report window.stop()', async ({ page, server }) => { await page.goto(server.PREFIX + '/window-stop.html'); }); -it('should return from goto if new navigation is started', async ({ page, server, browserName }) => { +it('should return from goto if new navigation is started', async ({ page, server, browserName, isAndroid }) => { it.fixme(browserName === 'webkit', 'WebKit has a bug where Page.frameStoppedLoading is sent too early.'); + it.fixme(isAndroid); server.setRoute('/slow.js', async (req, res) => void 0); let finished = false; const navigation = page.goto(server.PREFIX + '/load-event/load-event.html').then(r => { diff --git a/tests/page/page-request-fulfill.spec.ts b/tests/page/page-request-fulfill.spec.ts index 754df5cf70..abcdb3ffe9 100644 --- a/tests/page/page-request-fulfill.spec.ts +++ b/tests/page/page-request-fulfill.spec.ts @@ -121,8 +121,8 @@ it('should allow mocking svg with charset', async ({ page, server, browserName, expect(await img.screenshot()).toMatchSnapshot('mock-svg.png'); }); -it('should work with file path', async ({ page, server, asset, mode }) => { - it.skip(mode === 'service'); +it('should work with file path', async ({ page, server, asset, mode, isAndroid }) => { + it.skip(mode === 'service' || isAndroid); await page.route('**/*', route => route.fulfill({ contentType: 'shouldBeIgnored', path: asset('pptr.png') })); await page.evaluate(PREFIX => { @@ -289,7 +289,8 @@ it('should fulfill with multiple set-cookie', async ({ page, server, isElectron expect(await response.headerValue('X-Header-2')).toBe('v2'); }); -it('should fulfill with fetch response that has multiple set-cookie', async ({ playwright, page, server }) => { +it('should fulfill with fetch response that has multiple set-cookie', async ({ playwright, page, server, isAndroid }) => { + it.fixme(isAndroid); server.setRoute('/empty.html', (req, res) => { res.setHeader('Set-Cookie', ['a=b', 'c=d']); res.setHeader('Content-Type', 'text/html');