From 98fa984e8d091cda5433a836addbc7e3d8d4b98c Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 27 Feb 2024 09:46:55 -0800 Subject: [PATCH] docs: better addLocatorHandler example in release notes --- docs/src/release-notes-js.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/src/release-notes-js.md b/docs/src/release-notes-js.md index 16ad193eba..e8fe6194ae 100644 --- a/docs/src/release-notes-js.md +++ b/docs/src/release-notes-js.md @@ -13,13 +13,13 @@ import LiteYouTube from '@site/src/components/LiteYouTube'; - New method [`method: Page.addLocatorHandler`] registers a callback that will be invoked when specified element becomes visible and may block Playwright actions. The callback can get rid of the overlay. Here is an example that closes a cookie dialog when it appears: ```js // Setup the handler. -await page.addLocatorHandler(page.getByRole('button', { name: 'Accept all cookies' }), async () => { - await page.getByRole('button', { name: 'Reject all cookies' }).click(); +await page.addLocatorHandler(page.getByRole('heading', { name: 'Hej! You are in control of your cookies.' }), async () => { + await page.getByRole('button', { name: 'Accept all' }).click(); }); - // Write the test as usual. -await page.goto('https://example.com'); -await page.getByRole('button', { name: 'Start here' }).click(); +await page.goto('https://www.ikea.com/'); +await page.getByRole('link', { name: 'Collection of blue and white' }).click(); +await expect(page.getByRole('heading', { name: 'Light and easy' })).toBeVisible(); ``` - `expect(callback).toPass()` timeout can now be configured by `expect.toPass.timeout` option [globally](./api/class-testconfig#test-config-expect) or in [project config](./api/class-testproject#test-project-expect)