Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chery-pick(#17273): chore(dotnet): no nested namespace in transport channels (#17303)

Browse source 
This PR cherry-picks the following commits:

- c7367b7065

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This commit is contained in:
Playwright Service 2022-09-13 09:52:57 -07:00 committed by GitHub
parent 344077b04e
commit 991f2f9417
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
utils/doclint/generateDotnetApi.js
View file

@ -226,11 +226,6 @@ for (const [name, type] of modelTypes)
for (const [name, literals] of enumTypes)
renderEnum(name, literals);
if (process.argv[3] !== '--skip-format') {
// run the formatting tool for .NET, to ensure the files are prepped
execSync(`dotnet format "${outputDir}"`);
}
/**
* @param {string} name
*/

7
utils/generate_dotnet_channels.js
View file

@ -209,11 +209,10 @@ function writeCSharpClass(className, inheritFrom, serializedProperties) {
channels_ts.push('using System.Collections.Generic;');
channels_ts.push('using System.Text.Json.Serialization;');
channels_ts.push(``);
channels_ts.push(`namespace Microsoft.Playwright.Transport.Protocol`);
channels_ts.push(`{`);
channels_ts.push(` internal class ${className}${inheritFrom ? ' : ' + inheritFrom : ''}`);
channels_ts.push(`namespace Microsoft.Playwright.Transport.Protocol;`);
channels_ts.push(``);
channels_ts.push(`internal class ${className}${inheritFrom ? ' : ' + inheritFrom : ''}`);
channels_ts.push(serializedProperties);
channels_ts.push(`}`);
channels_ts.push(``);
writeFile(`${className}.cs`, channels_ts.join('\n'));
}