Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

tests: explicitly close contexts for browser.newPage (#875)

Browse source
This commit is contained in:
Pavel Feldman 2020-02-06 15:18:07 -08:00 committed by GitHub
parent 126eb505e8
commit 99d06892c5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/browser.spec.js
View file

@ -22,13 +22,13 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
describe('Browser', function() { describe('Browser', function() {
it('should create new page', async function({browser}) { it('should create new page', async function({browser, newPage}) {
expect((await browser.pages()).length).toBe(0); expect((await browser.pages()).length).toBe(0);
const page1 = await browser.newPage(); const page1 = await newPage();
expect((await browser.pages()).length).toBe(1); expect((await browser.pages()).length).toBe(1);
expect(browser.browserContexts().length).toBe(1); expect(browser.browserContexts().length).toBe(1);
const page2 = await browser.newPage(); const page2 = await newPage();
expect((await browser.pages()).length).toBe(2); expect((await browser.pages()).length).toBe(2);
expect(browser.browserContexts().length).toBe(2); expect(browser.browserContexts().length).toBe(2);

2
test/chromium/chromium.spec.js
View file

@ -189,7 +189,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
const target = await targetPromise; const target = await targetPromise;
expect(await target.page()).toBe(page); expect(await target.page()).toBe(page);
await page.close(); await page.browserContext().close();
}); });
it('should fire target events', async function({browser, newContext, server}) { it('should fire target events', async function({browser, newContext, server}) {
const context = await newContext(); const context = await newContext();

2
test/chromium/tracing.spec.js
View file

@ -55,7 +55,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
const newPage = await browser.newPage(); const newPage = await browser.newPage();
let error = null; let error = null;
await browser.startTracing(newPage, {path: outputFile}).catch(e => error = e); await browser.startTracing(newPage, {path: outputFile}).catch(e => error = e);
await newPage.close(); await newPage.browserContext().close();
expect(error).toBeTruthy(); expect(error).toBeTruthy();
await browser.stopTracing(); await browser.stopTracing();
}); });

2
test/web.spec.js
View file

@ -43,7 +43,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
afterEach(async state => { afterEach(async state => {
await state.page.evaluate(() => teardown()); await state.page.evaluate(() => teardown());
await state.page.close(); await state.page.browserContext().close();
state.page = null; state.page = null;
}); });

2
utils/protocol-types-generator/index.js
View file

@ -16,7 +16,7 @@ async function generateChromiunProtocol(revision) {
const page = await browser.newPage(); const page = await browser.newPage();
await page.goto(`http://${origin}/json/protocol`); await page.goto(`http://${origin}/json/protocol`);
const json = JSON.parse(await page.evaluate(() => document.documentElement.innerText)); const json = JSON.parse(await page.evaluate(() => document.documentElement.innerText));
await browserServer.kill(); await browserServer.close();
fs.writeFileSync(outputPath, jsonToTS(json)); fs.writeFileSync(outputPath, jsonToTS(json));
console.log(`Wrote protocol.ts to ${path.relative(process.cwd(), outputPath)}`); console.log(`Wrote protocol.ts to ${path.relative(process.cwd(), outputPath)}`);
} }