From 99d4887053a3dd361e90b30b222f1a4a3ef40c2a Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Sat, 22 Apr 2023 04:45:41 +0000 Subject: [PATCH] feat(firefox): roll to r1403 (#22540) Fixes https://github.com/microsoft/playwright/issues/22082 Fixes https://github.com/microsoft/playwright/issues/20993 --- packages/playwright-core/browsers.json | 4 ++-- tests/library/headful.spec.ts | 6 ++---- tests/page/page-click.spec.ts | 4 ---- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index a8571d6076..7bc5815ca9 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -21,13 +21,13 @@ }, { "name": "firefox", - "revision": "1399", + "revision": "1403", "installByDefault": true, "browserVersion": "112.0" }, { "name": "firefox-beta", - "revision": "1400", + "revision": "1404", "installByDefault": false, "browserVersion": "113.0b3" }, diff --git a/tests/library/headful.spec.ts b/tests/library/headful.spec.ts index 4344d3d361..22cb8033b7 100644 --- a/tests/library/headful.spec.ts +++ b/tests/library/headful.spec.ts @@ -65,9 +65,8 @@ it('should not crash when creating second context', async ({ browser }) => { } }); -it('should click when viewport size is larger than screen', async ({ page, browserName }) => { +it('should click when viewport size is larger than screen', async ({ page }) => { it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/22082' }); - it.fixme(browserName === 'firefox'); await page.setViewportSize({ width: 3000, height: 3000, @@ -81,9 +80,8 @@ it('should click when viewport size is larger than screen', async ({ page, brows await page.locator('button').click(); }); -it('should dispatch click events to oversized viewports', async ({ page, browserName }) => { +it('should dispatch click events to oversized viewports', async ({ page }) => { it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/22082' }); - it.fixme(browserName === 'firefox'); // Some prime numbers for width/height. const width = 2971; const height = 3067; diff --git a/tests/page/page-click.spec.ts b/tests/page/page-click.spec.ts index 5488621016..5ccc3013e5 100644 --- a/tests/page/page-click.spec.ts +++ b/tests/page/page-click.spec.ts @@ -144,8 +144,6 @@ it('should select the text by triple clicking', async ({ page, server }) => { }); it('should click offscreen buttons', async ({ page, server, browserName, headless }) => { - it.fixme(!headless && browserName === 'firefox' && process.platform === 'darwin', 'https://github.com/microsoft/playwright/issues/20993'); - await page.goto(server.PREFIX + '/offscreenbuttons.html'); const messages = []; page.on('console', msg => messages.push(msg.text())); @@ -414,7 +412,6 @@ it('should click the button with em border with offset', async ({ page, server, }); it('should click a very large button with offset', async ({ page, server, browserName }) => { - await page.goto(server.PREFIX + '/input/button.html'); await page.$eval('button', button => button.style.borderWidth = '8px'); await page.$eval('button', button => button.style.height = button.style.width = '2000px'); @@ -426,7 +423,6 @@ it('should click a very large button with offset', async ({ page, server, browse }); it('should click a button in scrolling container with offset', async ({ page, server, browserName }) => { - await page.goto(server.PREFIX + '/input/button.html'); await page.$eval('button', button => { const container = document.createElement('div');