Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(firefox): prepare to fission roll (#18302)

Browse source 
- Handle `Runtime.executionContextsCleared` event.
- Skip one auto-waiting test, because navigations now happen
asynchronously.
This commit is contained in:
Dmitry Gozman 2022-10-24 16:03:56 -07:00 committed by GitHub
parent ab78865a8d
commit 9a684d39ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/playwright-core/src/server/firefox/ffPage.ts
View file

@ -79,6 +79,7 @@ export class FFPage implements PageDelegate {
eventsHelper.addEventListener(this._session, 'Page.sameDocumentNavigation', this._onSameDocumentNavigation.bind(this)), eventsHelper.addEventListener(this._session, 'Page.sameDocumentNavigation', this._onSameDocumentNavigation.bind(this)),
eventsHelper.addEventListener(this._session, 'Runtime.executionContextCreated', this._onExecutionContextCreated.bind(this)), eventsHelper.addEventListener(this._session, 'Runtime.executionContextCreated', this._onExecutionContextCreated.bind(this)),
eventsHelper.addEventListener(this._session, 'Runtime.executionContextDestroyed', this._onExecutionContextDestroyed.bind(this)), eventsHelper.addEventListener(this._session, 'Runtime.executionContextDestroyed', this._onExecutionContextDestroyed.bind(this)),
eventsHelper.addEventListener(this._session, 'Runtime.executionContextsCleared', this._onExecutionContextsCleared.bind(this)),
eventsHelper.addEventListener(this._session, 'Page.linkClicked', event => this._onLinkClicked(event.phase)), eventsHelper.addEventListener(this._session, 'Page.linkClicked', event => this._onLinkClicked(event.phase)),
eventsHelper.addEventListener(this._session, 'Page.uncaughtError', this._onUncaughtError.bind(this)), eventsHelper.addEventListener(this._session, 'Page.uncaughtError', this._onUncaughtError.bind(this)),
eventsHelper.addEventListener(this._session, 'Runtime.console', this._onConsole.bind(this)), eventsHelper.addEventListener(this._session, 'Runtime.console', this._onConsole.bind(this)),
@ -184,6 +185,11 @@ export class FFPage implements PageDelegate {
context.frame._contextDestroyed(context); context.frame._contextDestroyed(context);
} }
_onExecutionContextsCleared() {
for (const executionContextId of Array.from(this._contextIdToContext.keys()))
this._onExecutionContextDestroyed({ executionContextId });
}
private _removeContextsForFrame(frame: frames.Frame) { private _removeContextsForFrame(frame: frames.Frame) {
for (const [contextId, context] of this._contextIdToContext) { for (const [contextId, context] of this._contextIdToContext) {
if (context.frame === frame) if (context.frame === frame)

4
tests/page/page-autowaiting-basic.spec.ts
View file

@ -164,7 +164,9 @@ it('should await navigation when assigning location twice', async ({ page, serve
expect(messages.join('|')).toBe('routeoverride|evaluate'); expect(messages.join('|')).toBe('routeoverride|evaluate');
}); });
it('should await navigation when evaluating reload', async ({ page, server }) => { it('should await navigation when evaluating reload', async ({ page, server, browserName }) => {
it.fixme(browserName === 'firefox', 'With fission enabled, navigations in Firefox start asynchronously');
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
const messages = initServer(server); const messages = initServer(server);
await Promise.all([ await Promise.all([