From 9b08871b4d3a056da98dc2f3e582c47727b530e7 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Wed, 15 Sep 2021 16:28:57 -0700
Subject: [PATCH] fix(test runner): print flaky tests summary in yellow, not in
 red (#8951)

---
 src/test/reporters/base.ts | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/src/test/reporters/base.ts b/src/test/reporters/base.ts
index d5f8585bf4..1b03aa6ae9 100644
--- a/src/test/reporters/base.ts
+++ b/src/test/reporters/base.ts
@@ -121,11 +121,13 @@ export class BaseReporter implements Reporter  {
     console.log('');
     if (unexpected.length) {
       console.log(colors.red(`  ${unexpected.length} failed`));
-      this._printTestHeaders(unexpected);
+      for (const test of unexpected)
+        console.log(colors.red(formatTestHeader(this.config, test, '    ')));
     }
     if (flaky.length) {
-      console.log(colors.red(`  ${flaky.length} flaky`));
-      this._printTestHeaders(flaky);
+      console.log(colors.yellow(`  ${flaky.length} flaky`));
+      for (const test of flaky)
+        console.log(colors.yellow(formatTestHeader(this.config, test, '    ')));
     }
     if (skipped)
       console.log(colors.yellow(`  ${skipped} skipped`));
@@ -135,12 +137,6 @@ export class BaseReporter implements Reporter  {
       console.log(colors.red(`  Timed out waiting ${this.config.globalTimeout / 1000}s for the entire test run`));
   }
 
-  private _printTestHeaders(tests: TestCase[]) {
-    tests.forEach(test => {
-      console.log(formatTestHeader(this.config, test, '    '));
-    });
-  }
-
   private _printFailures(failures: TestCase[]) {
     failures.forEach((test, index) => {
       console.log(formatFailure(this.config, test, index + 1, this.printTestOutput));
@@ -154,7 +150,7 @@ export class BaseReporter implements Reporter  {
 
 export function formatFailure(config: FullConfig, test: TestCase, index?: number, stdio?: boolean): string {
   const lines: string[] = [];
-  lines.push(formatTestHeader(config, test, '  ', index));
+  lines.push(colors.red(formatTestHeader(config, test, '  ', index)));
   for (const result of test.results) {
     const resultTokens = formatResultFailure(test, result, '    ');
     if (!resultTokens.length)
@@ -239,7 +235,7 @@ export function formatTestTitle(config: FullConfig, test: TestCase, step?: TestS
 function formatTestHeader(config: FullConfig, test: TestCase, indent: string, index?: number): string {
   const title = formatTestTitle(config, test);
   const header = `${indent}${index ? index + ') ' : ''}${title}`;
-  return colors.red(pad(header, '='));
+  return pad(header, '=');
 }
 
 export function formatError(error: TestError, file?: string) {