From 9c29f24c65d8fe26bc804b467507d02eb3e967cc Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Fri, 28 Apr 2023 16:56:28 -0700 Subject: [PATCH] chore: poll test result along with the live trace (#22714) Fixes: https://github.com/microsoft/playwright/issues/22656 --- packages/trace-viewer/src/ui/uiModeView.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/trace-viewer/src/ui/uiModeView.tsx b/packages/trace-viewer/src/ui/uiModeView.tsx index 16076936e5..8e18a0ca3b 100644 --- a/packages/trace-viewer/src/ui/uiModeView.tsx +++ b/packages/trace-viewer/src/ui/uiModeView.tsx @@ -483,10 +483,9 @@ const TraceView: React.FC<{ const [counter, setCounter] = React.useState(0); const pollTimer = React.useRef(null); - const { outputDir, result } = React.useMemo(() => { + const { outputDir } = React.useMemo(() => { const outputDir = item.testCase ? outputDirForTestCase(item.testCase) : undefined; - const result = item.testCase?.results[0]; - return { outputDir, result }; + return { outputDir }; }, [item]); // Preserve user selection upon live-reloading trace model by persisting the action id. @@ -499,6 +498,7 @@ const TraceView: React.FC<{ if (pollTimer.current) clearTimeout(pollTimer.current); + const result = item.testCase?.results[0]; if (!result) { setModel(undefined); return; @@ -532,7 +532,7 @@ const TraceView: React.FC<{ if (pollTimer.current) clearTimeout(pollTimer.current); }; - }, [result, outputDir, item, setModel, counter, setCounter]); + }, [outputDir, item, setModel, counter, setCounter]); return