From 9d88147b80e34a7081ddbe2b7cb51ff84d656d25 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Tue, 29 Oct 2024 14:05:23 +0100 Subject: [PATCH] also turn show-trace parameters into http urls --- .../src/server/trace/viewer/traceViewer.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts index a49148e061..a2251c5e22 100644 --- a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts +++ b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts @@ -106,8 +106,16 @@ export async function installRootRedirect(server: HttpServer, traceUrls: string[ const params = new URLSearchParams(); if (path.sep !== path.posix.sep) params.set('pathSeparator', path.sep); - for (const traceUrl of traceUrls) - params.append('trace', traceUrl); + for (const traceUrl of traceUrls) { + if (traceUrl.startsWith('http://') || traceUrl.startsWith('https://')) { + params.append('trace', traceUrl); + continue; + } + + const url = new URL('/trace/file', server.urlPrefix('precise')); + url.searchParams.set('path', traceUrl); + params.append('trace', url.toString()); + } if (server.wsGuid()) params.append('ws', server.wsGuid()!); if (options?.isServer)