Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Signed-off-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Max Schmitt 2024-06-19 12:52:05 +02:00 committed by GitHub
parent f591cb73ad
commit 9df141bb95
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
docs/src/test-parameterize-js.md
View file

@ -17,14 +17,14 @@ You can either parameterize tests on a test level or on a project level.
// You can also do it with test.describe() or with multiple tests as long the test name is unique.
test(`testing with ${name}`, async ({ page }) => {
await page.goto(`/greet?name=${name}`);
await expect(page.getByRole('heading', { name })).toBeVisible();
await expect(page.getByRole('heading')).toHaveText(expected);
});
});
```
### Before and after hooks
When looping over `before{Each,All}` or `after{Each,All}` hooks, they will be executed for every iteration, so in most cases, you should loop only over tests:
Most of the time you should put `beforeEach`, `beforeAll`, `afterEach` and `afterAll` hooks outside of `forEach`, so that hooks are executed just once:
```js title="example.spec.ts"
test.beforeEach(async ({ page }) => {
@ -42,7 +42,7 @@ test.afterEach(async ({ page }) => {
].forEach(({ name, expected }) => {
test(`testing with ${name}`, async ({ page }) => {
await page.goto(`/greet?name=${name}`);
await expect(page.getByRole('heading', { name })).toBeVisible();
await expect(page.getByRole('heading')).toHaveText(expected);
});
});
```