Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(oopifs): ignore target closure when broadcasting across oopifs (#5246)

Browse source
This commit is contained in:
Dmitry Gozman 2021-02-02 10:21:42 -08:00 committed by GitHub
parent 5564b203d9
commit 9e09bd369d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/server/chromium/crPage.ts
View file

@ -93,7 +93,17 @@ export class CRPage implements PageDelegate {
} }
private async _forAllFrameSessions(cb: (frame: FrameSession) => Promise<any>) { private async _forAllFrameSessions(cb: (frame: FrameSession) => Promise<any>) {
await Promise.all(Array.from(this._sessions.values()).map(frame => cb(frame))); const frameSessions = Array.from(this._sessions.values());
await Promise.all(frameSessions.map(frameSession => {
if (frameSession._isMainFrame())
return cb(frameSession);
return cb(frameSession).catch(e => {
// Broadcasting a message to the closed iframe shoule be a noop.
if (e.message && (e.message.includes('Target closed.') || e.message.includes('Session closed.')))
return;
throw e;
});
}));
} }
private _sessionForFrame(frame: frames.Frame): FrameSession { private _sessionForFrame(frame: frames.Frame): FrameSession {
@ -348,7 +358,7 @@ class FrameSession {
}); });
} }
private _isMainFrame(): boolean { _isMainFrame(): boolean {
return this._targetId === this._crPage._targetId; return this._targetId === this._crPage._targetId;
} }