Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#33821): fix(recorder): allow clearing when recording is disabled (#33900)

Browse source 
Co-authored-by: Simon Knott <info@simonknott.de>
This commit is contained in:
Dmitry Gozman 2024-12-06 13:44:10 -08:00 committed by GitHub
parent 9365eb5dac
commit 9e855d5b9a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 32 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/recorder/recorderCollection.ts
View file

@ -38,7 +38,7 @@ export class RecorderCollection extends EventEmitter {
restart() { restart() {
this._actions = []; this._actions = [];
this._fireChange(); this.emit('change', []);
} }
setEnabled(enabled: boolean) { setEnabled(enabled: boolean) {
@ -128,6 +128,7 @@ export class RecorderCollection extends EventEmitter {
private _fireChange() { private _fireChange() {
if (!this._enabled) if (!this._enabled)
return; return;
this.emit('change', collapseActions(this._actions)); this.emit('change', collapseActions(this._actions));
} }
} }

30
tests/library/inspector/cli-codegen-1.spec.ts
View file

@ -926,4 +926,34 @@ await page.GetByRole(AriaRole.Button, new() { Name = "Submit" }).ClickAsync();`)
const predicate = (msg: ConsoleMessage) => msg.type() === 'error' && /Content[\- ]Security[\- ]Policy/i.test(msg.text()); const predicate = (msg: ConsoleMessage) => msg.type() === 'error' && /Content[\- ]Security[\- ]Policy/i.test(msg.text());
await expect(page.waitForEvent('console', { predicate, timeout: 1000 })).rejects.toThrow(); await expect(page.waitForEvent('console', { predicate, timeout: 1000 })).rejects.toThrow();
}); });
test('should clear when recording is disabled', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/33802' } }, async ({ openRecorder }) => {
const { recorder } = await openRecorder();
await recorder.setContentAndWait(`
<button id="foo" onclick="console.log('click')">Foo</button>
<button id="bar" onclick="console.log('click')">Bar</button>
`);
await recorder.hoverOverElement('#foo');
let [sources] = await Promise.all([
recorder.waitForOutput('JavaScript', 'click'),
recorder.trustedClick(),
]);
expect(sources.get('JavaScript').text).toContain(`getByRole('button', { name: 'Foo' }).click()`);
await recorder.recorderPage.getByRole('button', { name: 'Record' }).click();
await recorder.recorderPage.getByRole('button', { name: 'Clear' }).click();
await recorder.recorderPage.getByRole('button', { name: 'Record' }).click();
await recorder.hoverOverElement('#bar');
[sources] = await Promise.all([
recorder.waitForOutput('JavaScript', 'click'),
recorder.trustedClick(),
]);
expect(sources.get('JavaScript').text).toContain(`getByRole('button', { name: 'Bar' }).click()`);
expect(sources.get('JavaScript').text).not.toContain(`getByRole('button', { name: 'Foo' })`);
});
}); });