From 9ee8b8e2a9c477e91b6f6b73172d213c6c10d61a Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Thu, 14 Mar 2024 18:03:06 +0100 Subject: [PATCH] Apply suggestions from code review Signed-off-by: Max Schmitt --- tests/page/page-set-input-files.spec.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/page/page-set-input-files.spec.ts b/tests/page/page-set-input-files.spec.ts index 210a955886..9f217c0081 100644 --- a/tests/page/page-set-input-files.spec.ts +++ b/tests/page/page-set-input-files.spec.ts @@ -37,7 +37,7 @@ it('should upload the file', async ({ page, server, asset }) => { }, input)).toBe('contents of the file'); }); -it('should upload the file with a popup which opened/closed before', async ({ page, server, asset, browserName }) => { +it('should upload the file after popup', async ({ page, server, asset, browserName }) => { it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/29923' }); it.fixme(browserName === 'firefox'); await page.goto(server.PREFIX + '/input/fileupload.html'); @@ -47,7 +47,6 @@ it('should upload the file with a popup which opened/closed before', async ({ pa page.evaluate(() => window['__popup'] = window.open('about:blank')), ]); await popup.close(); - await page.waitForTimeout(1000) } const filePath = path.relative(process.cwd(), asset('file-to-upload.txt')); const input = await page.$('input');