chore: follow-up on Electron launch

2024-04-19 00:00:06 +02:00 · 2024-04-19 00:00:06 +02:00 · a043d95207
parent 82aefd24db
commit a043d95207
1 changed files with 3 additions and 1 deletions
--- a/packages/playwright-core/src/server/electron/electron.ts
+++ b/packages/playwright-core/src/server/electron/electron.ts
@ -208,7 +208,9 @@ export class Electron extends SdkObject {
          progress.log(message);
          browserLogsCollector.log(message);
        },
-        shell: true,
+        // On Windows in order to run .cmd files, shell: true is required.
+        // https://github.com/nodejs/node/issues/52554
+        shell: process.platform === 'win32',
        stdio: 'pipe',
        cwd: options.cwd,
        tempDirectories: [artifactsDir],