From a0fa70a14b11a14447e16a1c6a27573ab242d037 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Tue, 12 Nov 2024 11:35:21 +0100 Subject: [PATCH] update stringLiteral implementations --- packages/trace-viewer/src/ui/codegen.ts | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/trace-viewer/src/ui/codegen.ts b/packages/trace-viewer/src/ui/codegen.ts index 3c8fc1e012..2d77177a0a 100644 --- a/packages/trace-viewer/src/ui/codegen.ts +++ b/packages/trace-viewer/src/ui/codegen.ts @@ -93,6 +93,8 @@ class JSCodeGen implements APIRequestCodegen { private stringLiteral(v: string): string { v = v.replace(/\\/g, '\\\\').replace(/'/g, '\\\''); + if (v.includes('\n') || v.includes('\r') || v.includes('\t')) + return '`' + v + '`'; return `'${v}'`; } } @@ -170,8 +172,7 @@ class PythonCodeGen implements APIRequestCodegen { } private stringLiteral(v: string): string { - v = v.replace(/\\/g, '\\\\').replace(/"/g, '\\"'); - return `"${v}"`; + return JSON.stringify(v); } } @@ -254,9 +255,7 @@ class CSharpCodeGen implements APIRequestCodegen { } private stringLiteral(v: string): string { - // escape douvle quotes and backslashes - v = v.replace(/\\/g, '\\\\').replace(/"/g, '\\"'); - return `"${v}"`; + return JSON.stringify(v); } } @@ -286,9 +285,7 @@ class JavaCodeGen implements APIRequestCodegen { } private stringLiteral(v: string): string { - // escape douvle quotes and backslashes - v = v.replace(/\\/g, '\\\\').replace(/"/g, '\\"'); - return `"${v}"`; + return JSON.stringify(v); } }