Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

docs: fix nested union handling (#5341)

Browse source
This commit is contained in:
Yury Semikhatsky 2021-02-05 16:32:13 -08:00 committed by GitHub
parent 983e04374a
commit a1b3164864
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/src/api/class-elementhandle.md
View file

@ -734,7 +734,7 @@ to pass. This method throws when the element is detached while waiting, unless w
If the element does not satisfy the condition for the [`option: timeout`] milliseconds, this method will throw. If the element does not satisfy the condition for the [`option: timeout`] milliseconds, this method will throw.
### param: ElementHandle.waitForElementState.state ### param: ElementHandle.waitForElementState.state
- `state` <"visible"|"hidden"|"stable"|"enabled"|"disabled"|"editable"> - `state` <[ElementStateEnum]<"visible"|"hidden"|"stable"|"enabled"|"disabled"|"editable">>
A state to wait for, see below for more details. A state to wait for, see below for more details.

11
utils/doclint/documentation.js
View file

@ -429,11 +429,14 @@ Documentation.Type = class {
*/ */
static fromParsedType(parsedType, inUnion = false) { static fromParsedType(parsedType, inUnion = false) {
if (!inUnion && parsedType.union) { if (!inUnion && parsedType.union) {
const name = parsedType.unionName || ''; const type = new Documentation.Type(parsedType.unionName || '');
const type = new Documentation.Type(name);
type.union = []; type.union = [];
for (let t = parsedType; t; t = t.union) for (let t = parsedType; t; t = t.union) {
type.union.push(Documentation.Type.fromParsedType(t, true)); const nestedUnion = !!t.unionName && t !== parsedType;
type.union.push(Documentation.Type.fromParsedType(t, !nestedUnion));
if (nestedUnion)
break;
}
return type; return type;
} }