Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(firefox): do not create first window on start (#1727)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-04-10 14:12:30 -07:00 committed by GitHub
parent 99c3f2b279
commit a1ffed6052
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/server/firefox.ts
View file

@ -185,8 +185,13 @@ export class Firefox implements BrowserType<FFBrowser> {
firefoxArguments.push('-juggler', String(port)); firefoxArguments.push('-juggler', String(port));
firefoxArguments.push(...args); firefoxArguments.push(...args);
if (args.every(arg => arg.startsWith('-'))) if (launchType === 'persistent') {
firefoxArguments.push('about:blank'); if (args.every(arg => arg.startsWith('-')))
firefoxArguments.push('about:blank');
} else {
firefoxArguments.push('-silent');
}
return firefoxArguments; return firefoxArguments;
} }
} }

1
test/fixtures.spec.js
View file

@ -26,6 +26,7 @@ async function testSignal(browserType, action, exitOnClose) {
handleSIGINT: true, handleSIGINT: true,
handleSIGTERM: true, handleSIGTERM: true,
handleSIGHUP: true, handleSIGHUP: true,
executablePath: browserType.executablePath(),
}); });
const res = spawn('node', [path.join(__dirname, 'fixtures', 'closeme.js'), playwrightPath, browserType.name(), JSON.stringify(options), exitOnClose ? 'true' : '']); const res = spawn('node', [path.join(__dirname, 'fixtures', 'closeme.js'), playwrightPath, browserType.name(), JSON.stringify(options), exitOnClose ? 'true' : '']);
let wsEndPointCallback; let wsEndPointCallback;