Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: setup plugins and provide proper config options

Browse source
This commit is contained in:
Simon Knott 2024-07-24 10:50:50 +02:00
parent 2d8c3d6800
commit a237dfbf43
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
3 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/playwright-ct-core/src/vitePlugin.ts
View file

@ -48,6 +48,10 @@ export function createPlugin(): TestRunnerPlugin {
configDir = configDirectory; configDir = configDirectory;
}, },
populateDependencies: async (config: FullConfig, configDir: string) => {
await buildBundle(config, configDir);
},
begin: async (suite: Suite) => { begin: async (suite: Suite) => {
const result = await buildBundle(config, configDir); const result = await buildBundle(config, configDir);
if (!result) if (!result)
@ -69,10 +73,6 @@ export function createPlugin(): TestRunnerPlugin {
if (stoppableServer) if (stoppableServer)
await new Promise(f => stoppableServer.stop(f)); await new Promise(f => stoppableServer.stop(f));
}, },
populateDependencies: async () => {
await buildBundle(config, configDir);
},
}; };
} }

2
packages/playwright/src/plugins/index.ts
View file

@ -20,7 +20,7 @@ import type { ReporterV2 } from '../reporters/reporterV2';
export interface TestRunnerPlugin { export interface TestRunnerPlugin {
name: string; name: string;
setup?(config: FullConfig, configDir: string, reporter: ReporterV2): Promise<void>; setup?(config: FullConfig, configDir: string, reporter: ReporterV2): Promise<void>;
populateDependencies?(): Promise<void>; populateDependencies?(config: FullConfig, configDir: string): Promise<void>;
begin?(suite: Suite): Promise<void>; begin?(suite: Suite): Promise<void>;
end?(): Promise<void>; end?(): Promise<void>;
teardown?(): Promise<void>; teardown?(): Promise<void>;

9
packages/playwright/src/runner/runner.ts
View file

@ -143,8 +143,13 @@ export class Runner {
return { errors: result.errors, testFiles: [] }; return { errors: result.errors, testFiles: [] };
const resolvedFiles = (files as string[]).map(file => path.resolve(process.cwd(), file)); const resolvedFiles = (files as string[]).map(file => path.resolve(process.cwd(), file));
for (const plugin of this._config.plugins)
await plugin.instance?.populateDependencies?.(); for (const plugin of this._config.plugins) {
if (!plugin.instance)
plugin.instance = typeof plugin.factory === 'function' ? await plugin.factory() : plugin.factory;
await plugin.instance.populateDependencies?.(this._config.config, this._config.configDir);
}
return { testFiles: affectedTestFiles(resolvedFiles) }; return { testFiles: affectedTestFiles(resolvedFiles) };
} }
} }