Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(webkit): unflake frame detach tests (#509)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-01-16 11:10:46 -08:00 committed by Dmitry Gozman
parent 9b46014493
commit a2c7553518
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/webkit/wkPageProxy.ts
View file

@ -67,7 +67,10 @@ export class WKPageProxy {
handleProvisionalLoadFailed(event: Protocol.Browser.provisionalLoadFailedPayload) { handleProvisionalLoadFailed(event: Protocol.Browser.provisionalLoadFailedPayload) {
if (!this._wkPage) if (!this._wkPage)
return; return;
this._wkPage._page._frameManager.provisionalLoadFailed(event.loaderId, event.error); let errorText = event.error;
if (errorText.includes('cancelled'))
errorText += '; maybe frame was detached?';
this._wkPage._page._frameManager.provisionalLoadFailed(event.loaderId, errorText);
} }
async page(): Promise<Page> { async page(): Promise<Page> {