Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

add nice todo

Browse source
This commit is contained in:
Simon Knott 2024-12-20 16:48:37 +01:00
parent c6cf6bcabf
commit a30a3bbe9d
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/playwright/src/plugins/webServerPlugin.ts
View file

@ -124,7 +124,10 @@ export class WebServerPlugin implements TestRunnerPlugin {
if (!signal)
throw new Error('skip graceful shutdown');
process.kill(-launchedProcess.pid!, signal);
// launchedProcess is a shell. not all shells forward signals to their child processes.
// we need to send the signal to the webserver inside the shell.
const webserverPid = launchedProcess.pid!; // TODO: get the actual pid of the webserver
process.kill(webserverPid, signal);
return new Promise<void>((resolve, reject) => {
const timer = timeout !== 0
? setTimeout(() => reject(new Error(`process didn't close gracefully within timeout, falling back to SIGKILL`)), timeout)