From a42cd4b9aa9fd3a47db14733b13d716f5e83e36b Mon Sep 17 00:00:00 2001
From: Pavel Feldman <pavel.feldman@gmail.com>
Date: Thu, 24 Sep 2020 10:45:20 -0700
Subject: [PATCH] test: mark screencast tests as flaky until ffmpeg migation
 (#3968)

---
 test/fixtures.spec.ts   |  1 +
 test/screencast.spec.ts | 10 ++++++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/test/fixtures.spec.ts b/test/fixtures.spec.ts
index b61f27e294..7a058fa054 100644
--- a/test/fixtures.spec.ts
+++ b/test/fixtures.spec.ts
@@ -47,6 +47,7 @@ defineTestFixture('stallingConnectedRemoteServer', async ({browserType, stalling
 
 it('should close the browser when the node process closes', test => {
   test.slow();
+  test.flaky('Flakes at least on WebKit Linux');
 }, async ({connectedRemoteServer, isWindows}) => {
   if (isWindows)
     execSync(`taskkill /pid ${connectedRemoteServer.child().pid} /T /F`);
diff --git a/test/screencast.spec.ts b/test/screencast.spec.ts
index 51150d722a..89c11fcf05 100644
--- a/test/screencast.spec.ts
+++ b/test/screencast.spec.ts
@@ -196,6 +196,7 @@ class VideoPlayer {
 
 describe('screencast', suite => {
   suite.slow();
+  suite.flaky('We should migrate these to ffmpeg');
 }, () => {
   it('should require artifactsPath', async ({browserType, defaultBrowserOptions}) => {
     const browser = await browserType.launch({
@@ -232,9 +233,7 @@ describe('screencast', suite => {
     expectAll(pixels, almostRed);
   });
 
-  it('should capture navigation', test => {
-    test.flaky();
-  }, async ({browser, server, videoPlayer, relativeArtifactsPath, videoDir}) => {
+  it('should capture navigation', async ({browser, server, videoPlayer, relativeArtifactsPath, videoDir}) => {
     const context = await browser.newContext({
       relativeArtifactsPath,
       recordVideos: true,
@@ -268,6 +267,7 @@ describe('screencast', suite => {
 
   it('should capture css transformation', (test, parameters) => {
     test.fail(options.WEBKIT(parameters) && options.WIN(parameters), 'Does not work on WebKit Windows');
+    test.fixme(!options.HEADLESS, 'Fails on headful');
   }, async ({browser, server, videoPlayer, relativeArtifactsPath, videoDir}) => {
     const size = {width: 320, height: 240};
     // Set viewport equal to screencast frame size to avoid scaling.
@@ -315,7 +315,9 @@ describe('screencast', suite => {
     expect(videoFiles.length).toBe(2);
   });
 
-  it('should scale frames down to the requested size ', async ({browser, videoPlayer, relativeArtifactsPath, videoDir, server}) => {
+  it('should scale frames down to the requested size ', test => {
+    test.fixme(!options.HEADLESS, 'Fails on headful');
+  }, async ({browser, videoPlayer, relativeArtifactsPath, videoDir, server}) => {
     const context = await browser.newContext({
       relativeArtifactsPath,
       recordVideos: true,