From a4563a85ce107d4412c188be025aba1ce5f92c0a Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Wed, 2 Sep 2020 10:20:52 -0700 Subject: [PATCH] fix(snapshot): remove integrity checksum for css (#3729) Otherwise we cannot override css with cssom changes. --- src/server/snapshotterInjected.ts | 2 ++ utils/showTestTraces.js | 23 ++++++++++++++++++++--- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/src/server/snapshotterInjected.ts b/src/server/snapshotterInjected.ts index bca9703f76..fd059aa971 100644 --- a/src/server/snapshotterInjected.ts +++ b/src/server/snapshotterInjected.ts @@ -168,6 +168,8 @@ export function takeSnapshotInFrame(guid: string, removeNoScript: boolean): Snap continue; if (name === 'checked' || name === 'disabled' || name === 'checked') continue; + if (nodeName === 'LINK' && name === 'integrity') + continue; if (name === 'src' && (nodeName === 'IFRAME' || nodeName === 'FRAME')) { // TODO: handle srcdoc? let protocol = win.location.protocol; diff --git a/utils/showTestTraces.js b/utils/showTestTraces.js index 5acd9a16ef..83607a9f1a 100644 --- a/utils/showTestTraces.js +++ b/utils/showTestTraces.js @@ -19,9 +19,26 @@ const fs = require('fs'); const playwright = require('..'); const { showTraceViewer } = require('../lib/trace/traceViewer'); -const testResultsDir = process.argv[2] || path.join(__dirname, '..', 'test-results'); -const files = collectFiles(testResultsDir, ''); -const traceStorageDir = path.join(testResultsDir, 'trace-storage'); +if (process.argv.includes('--help')) { + console.log(`Usage:`); + console.log(` - npm run show-trace`); + console.log(` Show traces from the last test run.`); + console.log(` - npm run show-trace `); + console.log(` Show traces from the downloaded test results.`); + console.log(` - npm run show-trace `); + console.log(` Show single trace file from the manual run.`); + process.exit(0); +} + +let traceStorageDir, files; +if (process.argv[3]) { + files = [process.argv[2]]; + traceStorageDir = process.argv[3]; +} else { + const testResultsDir = process.argv[2] || path.join(__dirname, '..', 'test-results'); + files = collectFiles(testResultsDir, ''); + traceStorageDir = path.join(testResultsDir, 'trace-storage'); +} console.log(`Found ${files.length} trace files`); showTraceViewer(playwright, traceStorageDir, files);