Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(test runner): add an overload for test.skip(title, fn) (#8454)

Browse source 
We shipped this feature, but forgot to add the right overload to d.ts.
This commit is contained in:
Dmitry Gozman 2021-08-25 14:36:36 -07:00 committed by GitHub
parent 204b6321b4
commit a479cb6f52
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/playwright-test/test-modifiers.spec.ts
View file

@ -179,6 +179,10 @@ test('test modifiers should check types', async ({runTSC}) => {
// @ts-expect-error // @ts-expect-error
test.skip(42); test.skip(42);
}); });
test.skip('skipped', async ({}) => {
});
// @ts-expect-error
test.skip('skipped', 'skipped');
`, `,
}); });
expect(result.exitCode).toBe(0); expect(result.exitCode).toBe(0);

1
types/test.d.ts vendored
View file

@ -1626,6 +1626,7 @@ export interface TestType<TestArgs extends KeyValue, WorkerArgs extends KeyValue
* skipped when the condition is `true`. * skipped when the condition is `true`.
* @param testFunctionOrDescription When used with `test.skip('test', () => {})` notation, second argument is a test function. Otherwise it is an optional description that will be reflected in a test report. * @param testFunctionOrDescription When used with `test.skip('test', () => {})` notation, second argument is a test function. Otherwise it is an optional description that will be reflected in a test report.
*/ */
skip(title: string, testFunction: (args: TestArgs, testInfo: TestInfo) => Promise<void> | void): void;
skip(): void; skip(): void;
skip(condition: boolean): void; skip(condition: boolean): void;
skip(condition: boolean, description: string): void; skip(condition: boolean, description: string): void;

1
utils/generate_types/overrides-test.d.ts vendored
View file

@ -227,6 +227,7 @@ export interface TestType<TestArgs extends KeyValue, WorkerArgs extends KeyValue
only: SuiteFunction; only: SuiteFunction;
}; };
}; };
skip(title: string, testFunction: (args: TestArgs, testInfo: TestInfo) => Promise<void> | void): void;
skip(): void; skip(): void;
skip(condition: boolean): void; skip(condition: boolean): void;
skip(condition: boolean, description: string): void; skip(condition: boolean, description: string): void;