From a494efed0f6345f3722a6e5813e7e00ae642f037 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 7 Jan 2020 12:41:37 -0800 Subject: [PATCH] chore(webkit): delete browser target agent (#402) --- package.json | 2 +- src/webkit/wkBrowser.ts | 6 ------ src/webkit/wkPageProxy.ts | 6 ++++++ 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 0634835152..0835b9ba21 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "playwright": { "chromium_revision": "724623", "firefox_revision": "1009", - "webkit_revision": "1066" + "webkit_revision": "1068" }, "scripts": { "unit": "node test/test.js", diff --git a/src/webkit/wkBrowser.ts b/src/webkit/wkBrowser.ts index 3173b0290f..92da4f154f 100644 --- a/src/webkit/wkBrowser.ts +++ b/src/webkit/wkBrowser.ts @@ -48,12 +48,6 @@ export class WKBrowser extends browser.Browser { ]; this._firstPageProxyPromise = new Promise(resolve => this._firstPageProxyCallback = resolve); - - // Intercept provisional targets during cross-process navigation. - this._connection.send('Target.setPauseOnStart', { pauseOnStart: true }).catch(e => { - debugError(e); - throw e; - }); } async newContext(options: BrowserContextOptions = {}): Promise { diff --git a/src/webkit/wkPageProxy.ts b/src/webkit/wkPageProxy.ts index 999096349c..fc9d2ce48d 100644 --- a/src/webkit/wkPageProxy.ts +++ b/src/webkit/wkPageProxy.ts @@ -32,6 +32,12 @@ export class WKPageProxy { helper.addEventListener(this._pageProxySession, WKPageProxySessionEvents.TargetDestroyed, this._onTargetDestroyed.bind(this)), helper.addEventListener(this._pageProxySession, WKPageProxySessionEvents.DidCommitProvisionalTarget, this._onProvisionalTargetCommitted.bind(this)) ]; + + // Intercept provisional targets during cross-process navigation. + this._pageProxySession.send('Target.setPauseOnStart', { pauseOnStart: true }).catch(e => { + debugError(e); + throw e; + }); } dispose() {