diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fcbc095f98..cfc111a1db 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,7 +17,7 @@ ### Getting Code -Make sure you're running Node.js 14+ and NPM 8+, to verify and upgrade NPM do: +Make sure you're running Node.js 16+ and NPM 8+, to verify and upgrade NPM do: ```bash node --version diff --git a/docs/src/troubleshooting.md b/docs/src/troubleshooting.md index ef8ab6d6e7..c2f81299f5 100644 --- a/docs/src/troubleshooting.md +++ b/docs/src/troubleshooting.md @@ -28,11 +28,11 @@ await page.evaluate(`(async() => { ## Node.js requirements * langs: js -Playwright requires Node.js version 14 or above +Playwright requires Node.js version 16 or above ### ReferenceError: URL is not defined -Playwright requires Node.js 14 or higher. +Playwright requires Node.js 16 or higher. ### Unknown file extension ".ts" diff --git a/package-lock.json b/package-lock.json index ff1db2196b..c666663f8e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -24,7 +24,7 @@ "@types/babel__core": "^7.20.0", "@types/codemirror": "^5.60.7", "@types/formidable": "^2.0.4", - "@types/node": "=14.18.34", + "@types/node": "^16.18.34", "@types/react": "^18.0.12", "@types/react-dom": "^18.0.5", "@types/resize-observer-browser": "^0.1.7", @@ -1505,9 +1505,9 @@ "dev": true }, "node_modules/@types/node": { - "version": "14.18.34", - "resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.34.tgz", - "integrity": "sha512-hcU9AIQVHmPnmjRK+XUUYlILlr9pQrsqSrwov/JK1pnf3GTQowVBhx54FbvM0AU/VXGH4i3+vgXS5EguR7fysA==" + "version": "16.18.34", + "resolved": "https://registry.npmjs.org/@types/node/-/node-16.18.34.tgz", + "integrity": "sha512-VmVm7gXwhkUimRfBwVI1CHhwp86jDWR04B5FGebMMyxV90SlCmFujwUHrxTD4oO+SOYU86SoxvhgeRQJY7iXFg==" }, "node_modules/@types/normalize-package-data": { "version": "2.4.1", @@ -2777,12 +2777,6 @@ "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.284.tgz", "integrity": "sha512-M8WEXFuKXMYMVr45fo8mq0wUrrJHheiKZf6BArTKk9ZBYCKJEOU5H8cdWgDT+qCVZf7Na4lVUaZsA+h6uA9+PA==" }, - "node_modules/electron/node_modules/@types/node": { - "version": "16.18.6", - "resolved": "https://registry.npmjs.org/@types/node/-/node-16.18.6.tgz", - "integrity": "sha512-vmYJF0REqDyyU0gviezF/KHq/fYaUbFhkcNbQCuPGFQj6VTbXuHZoxs/Y7mutWe73C8AC6l9fFu8mSYiBAqkGA==", - "dev": true - }, "node_modules/electron/node_modules/debug": { "version": "2.6.9", "dev": true, @@ -6227,6 +6221,9 @@ "packages/playwright-core": { "version": "1.35.0-next", "license": "Apache-2.0", + "bin": { + "playwright": "cli.js" + }, "engines": { "node": ">=14" } @@ -7472,9 +7469,9 @@ "dev": true }, "@types/node": { - "version": "14.18.34", - "resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.34.tgz", - "integrity": "sha512-hcU9AIQVHmPnmjRK+XUUYlILlr9pQrsqSrwov/JK1pnf3GTQowVBhx54FbvM0AU/VXGH4i3+vgXS5EguR7fysA==" + "version": "16.18.34", + "resolved": "https://registry.npmjs.org/@types/node/-/node-16.18.34.tgz", + "integrity": "sha512-VmVm7gXwhkUimRfBwVI1CHhwp86jDWR04B5FGebMMyxV90SlCmFujwUHrxTD4oO+SOYU86SoxvhgeRQJY7iXFg==" }, "@types/normalize-package-data": { "version": "2.4.1", @@ -8332,12 +8329,6 @@ "extract-zip": "^1.0.3" }, "dependencies": { - "@types/node": { - "version": "16.18.6", - "resolved": "https://registry.npmjs.org/@types/node/-/node-16.18.6.tgz", - "integrity": "sha512-vmYJF0REqDyyU0gviezF/KHq/fYaUbFhkcNbQCuPGFQj6VTbXuHZoxs/Y7mutWe73C8AC6l9fFu8mSYiBAqkGA==", - "dev": true - }, "debug": { "version": "2.6.9", "dev": true, diff --git a/package.json b/package.json index 3bae1fee3f..01e3b212a2 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" @@ -59,7 +59,7 @@ "@types/babel__core": "^7.20.0", "@types/codemirror": "^5.60.7", "@types/formidable": "^2.0.4", - "@types/node": "=14.18.34", + "@types/node": "^16.18.34", "@types/react": "^18.0.12", "@types/react-dom": "^18.0.5", "@types/resize-observer-browser": "^0.1.7", diff --git a/packages/playwright-chromium/package.json b/packages/playwright-chromium/package.json index 5a55134098..92c06ba3cb 100644 --- a/packages/playwright-chromium/package.json +++ b/packages/playwright-chromium/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-core/package.json b/packages/playwright-core/package.json index 5fdd881faf..6df52a314d 100644 --- a/packages/playwright-core/package.json +++ b/packages/playwright-core/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-core/src/common/socksProxy.ts b/packages/playwright-core/src/common/socksProxy.ts index 768d036cf3..0c78611e93 100644 --- a/packages/playwright-core/src/common/socksProxy.ts +++ b/packages/playwright-core/src/common/socksProxy.ts @@ -421,7 +421,7 @@ export class SocksProxy extends EventEmitter implements SocksConnectionClient { const localAddress = socket.localAddress; const localPort = socket.localPort; this._directSockets.set(request.uid, socket); - this._connections.get(request.uid)?.socketConnected(localAddress, localPort); + this._connections.get(request.uid)?.socketConnected(localAddress!, localPort!); } catch (error) { this._connections.get(request.uid)?.socketFailed(error.code); } @@ -557,7 +557,7 @@ export class SocksProxyHandler extends EventEmitter { const localAddress = socket.localAddress; const localPort = socket.localPort; this._sockets.set(uid, socket); - const payload: SocksSocketConnectedPayload = { uid, host: localAddress, port: localPort }; + const payload: SocksSocketConnectedPayload = { uid, host: localAddress!, port: localPort! }; debugLogger.log('socks', `[${uid}] <= connected to network ${payload.host}:${payload.port}`); this.emit(SocksProxyHandler.Events.SocksConnected, payload); } catch (error) { diff --git a/packages/playwright-ct-core/package.json b/packages/playwright-ct-core/package.json index 0817b4ca0c..705ef1a0be 100644 --- a/packages/playwright-ct-core/package.json +++ b/packages/playwright-ct-core/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-ct-react/package.json b/packages/playwright-ct-react/package.json index 9e8cdbcffc..32ca2a1cc3 100644 --- a/packages/playwright-ct-react/package.json +++ b/packages/playwright-ct-react/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-ct-react17/package.json b/packages/playwright-ct-react17/package.json index 1051733a82..b92c17b985 100644 --- a/packages/playwright-ct-react17/package.json +++ b/packages/playwright-ct-react17/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-ct-solid/package.json b/packages/playwright-ct-solid/package.json index 0100208238..77abb9fce3 100644 --- a/packages/playwright-ct-solid/package.json +++ b/packages/playwright-ct-solid/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-ct-svelte/package.json b/packages/playwright-ct-svelte/package.json index 20febb19e7..d58c3a1bfa 100644 --- a/packages/playwright-ct-svelte/package.json +++ b/packages/playwright-ct-svelte/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-ct-vue/package.json b/packages/playwright-ct-vue/package.json index 49af962e4a..be758550c1 100644 --- a/packages/playwright-ct-vue/package.json +++ b/packages/playwright-ct-vue/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-ct-vue2/package.json b/packages/playwright-ct-vue2/package.json index 9b50f2a974..68ba5aa816 100644 --- a/packages/playwright-ct-vue2/package.json +++ b/packages/playwright-ct-vue2/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-firefox/package.json b/packages/playwright-firefox/package.json index 9b25327d4e..890e636fde 100644 --- a/packages/playwright-firefox/package.json +++ b/packages/playwright-firefox/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright-test/package.json b/packages/playwright-test/package.json index 468a1d30f9..38ddbed619 100644 --- a/packages/playwright-test/package.json +++ b/packages/playwright-test/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "main": "index.js", "exports": { diff --git a/packages/playwright-test/src/common/process.ts b/packages/playwright-test/src/common/process.ts index 8b0cd4222b..8c84e63e6d 100644 --- a/packages/playwright-test/src/common/process.ts +++ b/packages/playwright-test/src/common/process.ts @@ -55,7 +55,7 @@ let processRunner: ProcessRunner; let processName: string; const startingEnv = { ...process.env }; -process.on('message', async message => { +process.on('message', async (message: any) => { if (message.method === '__init__') { const { processParams, runnerParams, runnerScript } = message.params as { processParams: ProcessInitParams, runnerParams: any, runnerScript: string }; setTtyParams(process.stdout, processParams.stdoutParams); diff --git a/packages/playwright-webkit/package.json b/packages/playwright-webkit/package.json index 3f76e965f9..f0aec9863f 100644 --- a/packages/playwright-webkit/package.json +++ b/packages/playwright-webkit/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation" diff --git a/packages/playwright/package.json b/packages/playwright/package.json index dc5cc0f8ce..234e3a8f66 100644 --- a/packages/playwright/package.json +++ b/packages/playwright/package.json @@ -5,7 +5,7 @@ "repository": "github:Microsoft/playwright", "homepage": "https://playwright.dev", "engines": { - "node": ">=14" + "node": ">=16" }, "author": { "name": "Microsoft Corporation"