Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Revert "fix(inspector): fix leaking event listeners (#22535)" (#22545)

Browse source 
This reverts commit 58b3c31f3e.

Reason for revert: UI rendering hits an infinite tight loop.
Reproduces locally with `npm run ctest pause.spec:357` (test hangs)
Also observed on dashboard:

<img width="1467" alt="image"
src="https://user-images.githubusercontent.com/746130/233541521-1f30338d-dd83-405c-bb0d-c890611c33e3.png">


https://github.com/microsoft/playwright/issues/22348
This commit is contained in:
Andrey Lushnikov 2023-04-21 04:35:01 +00:00 committed by GitHub
parent d95268ffc0
commit a56f97fcef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/web/src/components/codeMirrorWrapper.tsx
View file

@ -107,7 +107,7 @@ export const CodeMirrorWrapper: React.FC<SourceProps> = ({
React.useEffect(() => { React.useEffect(() => {
if (!codemirror) if (!codemirror)
return; return;
codemirror.off('change', (codemirror as any)[listenerSymbol]); codemirror.off('change', (codemirror as any).listenerSymbol);
(codemirror as any)[listenerSymbol] = undefined; (codemirror as any)[listenerSymbol] = undefined;
if (onChange) { if (onChange) {
(codemirror as any)[listenerSymbol] = () => onChange(codemirror.getValue()); (codemirror as any)[listenerSymbol] = () => onChange(codemirror.getValue());