From a66e4c0e5f544add101af3af52fd35f5b02b865b Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Fri, 25 Oct 2024 16:38:00 +0200 Subject: [PATCH] pipe sdkLanguage --- .../src/ui/networkResourceDetails.tsx | 15 ++++++++------- packages/trace-viewer/src/ui/networkTab.tsx | 6 ++++-- .../trace-viewer/src/ui/recorder/recorderView.tsx | 2 +- packages/trace-viewer/src/ui/workbench.tsx | 2 +- 4 files changed, 14 insertions(+), 11 deletions(-) diff --git a/packages/trace-viewer/src/ui/networkResourceDetails.tsx b/packages/trace-viewer/src/ui/networkResourceDetails.tsx index d4dc22a044..00dc443749 100644 --- a/packages/trace-viewer/src/ui/networkResourceDetails.tsx +++ b/packages/trace-viewer/src/ui/networkResourceDetails.tsx @@ -20,14 +20,16 @@ import './networkResourceDetails.css'; import { TabbedPane } from '@web/components/tabbedPane'; import { CodeMirrorWrapper } from '@web/components/codeMirrorWrapper'; import { ToolbarButton } from '@web/components/toolbarButton'; -import { fetchRequestPostData, generateCurlCommand, generateFetchCall } from '../third_party/devtools'; +import { generateCurlCommand, generateFetchCall } from '../third_party/devtools'; import { CopyToClipboardTextButton } from './copyToClipboard'; import { generatePlaywrightRequestCall } from '@isomorphic/codegen'; +import type { Language } from '@isomorphic/locatorGenerators'; export const NetworkResourceDetails: React.FunctionComponent<{ resource: ResourceSnapshot; onClose: () => void; -}> = ({ resource, onClose }) => { + sdkLanguage?: Language; +}> = ({ resource, onClose, sdkLanguage }) => { const [selectedTab, setSelectedTab] = React.useState('request'); return , + render: () => , }, { id: 'response', @@ -56,11 +58,10 @@ export const NetworkResourceDetails: React.FunctionComponent<{ const RequestTab: React.FunctionComponent<{ resource: ResourceSnapshot; -}> = ({ resource }) => { + sdkLanguage?: Language; +}> = ({ resource, sdkLanguage }) => { const [requestBody, setRequestBody] = React.useState<{ text: string, mimeType?: string } | null>(null); - const isJavascript = true; // TODO - React.useEffect(() => { const readResources = async () => { if (resource.request.postData) { @@ -99,7 +100,7 @@ const RequestTab: React.FunctionComponent<{
generateCurlCommand(resource)} /> generateFetchCall(resource)} /> - {isJavascript && generatePlaywrightRequestCall(resource.request, requestBody?.text)} />} + {sdkLanguage === 'javascript' && generatePlaywrightRequestCall(resource.request, requestBody?.text)} />}
{requestBody &&
Request Body
} diff --git a/packages/trace-viewer/src/ui/networkTab.tsx b/packages/trace-viewer/src/ui/networkTab.tsx index ec9156d9e6..104a039fe8 100644 --- a/packages/trace-viewer/src/ui/networkTab.tsx +++ b/packages/trace-viewer/src/ui/networkTab.tsx @@ -26,6 +26,7 @@ import { GridView, type RenderedGridCell } from '@web/components/gridView'; import { SplitView } from '@web/components/splitView'; import type { ContextEntry } from '../types/entries'; import { NetworkFilters, defaultFilterState, type FilterState, type ResourceType } from './networkFilters'; +import type { Language } from '@isomorphic/locatorGenerators'; type NetworkTabModel = { resources: Entry[], @@ -66,7 +67,8 @@ export const NetworkTab: React.FunctionComponent<{ boundaries: Boundaries, networkModel: NetworkTabModel, onEntryHovered?: (entry: Entry | undefined) => void, -}> = ({ boundaries, networkModel, onEntryHovered }) => { + sdkLanguage?: Language, +}> = ({ boundaries, networkModel, onEntryHovered, sdkLanguage }) => { const [sorting, setSorting] = React.useState(undefined); const [selectedEntry, setSelectedEntry] = React.useState(undefined); const [filterState, setFilterState] = React.useState(defaultFilterState); @@ -115,7 +117,7 @@ export const NetworkTab: React.FunctionComponent<{ sidebarIsFirst={true} orientation='horizontal' settingName='networkResourceDetails' - main={ setSelectedEntry(undefined)} />} + main={ setSelectedEntry(undefined)} sdkLanguage={sdkLanguage} />} sidebar={grid} />} ; diff --git a/packages/trace-viewer/src/ui/recorder/recorderView.tsx b/packages/trace-viewer/src/ui/recorder/recorderView.tsx index 6ff6b665d3..e9014a6cea 100644 --- a/packages/trace-viewer/src/ui/recorder/recorderView.tsx +++ b/packages/trace-viewer/src/ui/recorder/recorderView.tsx @@ -238,7 +238,7 @@ const PropertiesView: React.FunctionComponent<{ id: 'network', title: 'Network', count: networkModel.resources.length, - render: () => + render: () => }; const tabs: TabbedPaneTabModel[] = [ diff --git a/packages/trace-viewer/src/ui/workbench.tsx b/packages/trace-viewer/src/ui/workbench.tsx index 8e22917053..916bfec390 100644 --- a/packages/trace-viewer/src/ui/workbench.tsx +++ b/packages/trace-viewer/src/ui/workbench.tsx @@ -225,7 +225,7 @@ export const Workbench: React.FunctionComponent<{ id: 'network', title: 'Network', count: networkModel.resources.length, - render: () => + render: () => }; const attachmentsTab: TabbedPaneTabModel = { id: 'attachments',