Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Revert "fix: add 'window-management' to chromium browser (#31687)"

Browse source 
This reverts commit 0aa2f06f68.

Reference: https://github.com/microsoft/playwright/issues/27198
This commit is contained in:
Yury Semikhatsky 2024-07-22 10:16:05 -07:00
parent bef87849e3
commit a66e5a2dbd
4 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/src/api/class-browsercontext.md
View file

@ -980,7 +980,6 @@ A permission or an array of permissions to grant. Permissions can be one of the
* `'notifications'`
* `'payment-handler'`
* `'storage-access'`
* `'window-management'`
### option: BrowserContext.grantPermissions.origin
* since: v1.8

1
packages/playwright-core/src/server/chromium/crBrowser.ts
View file

@ -434,7 +434,6 @@ export class CRBrowserContext extends BrowserContext {
// chrome-specific permissions we have.
['midi-sysex', 'midiSysex'],
['storage-access', 'storageAccess'],
['window-management', 'windowManagement']
]);
const filtered = permissions.map(permission => {
const protocolPermission = webPermissionToProtocol.get(permission);

1
packages/playwright-core/types/types.d.ts vendored
View file

@ -8445,7 +8445,6 @@ export interface BrowserContext {
* - `'notifications'`
* - `'payment-handler'`
* - `'storage-access'`
* - `'window-management'`
* @param options
*/
grantPermissions(permissions: ReadonlyArray<string>, options?: {

8
tests/library/permissions.spec.ts
View file

@ -48,14 +48,6 @@ it.describe('permissions', () => {
expect(await getPermission(page, 'geolocation')).toBe('granted');
});
it('should grant window-management permission when origin is listed', async ({ page, context, server, browserName }) => {
it.skip(browserName !== 'chromium', 'Only Chromium supports window management API.');
await page.goto(server.EMPTY_PAGE);
await context.grantPermissions(['window-management'], { origin: server.EMPTY_PAGE });
expect(await getPermission(page, 'window-management')).toBe('granted');
});
it('should prompt for geolocation permission when origin is not listed', async ({ page, context, server }) => {
await page.goto(server.EMPTY_PAGE);
await context.grantPermissions(['geolocation'], { origin: server.EMPTY_PAGE });