From a8119209fe8974c8c2f35031de9ac2b8981341b4 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 18 Dec 2019 14:35:03 -0800 Subject: [PATCH] tests(webkit): mark Page.navigate to invalid URL test as passing --- package.json | 2 +- test/navigation.spec.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 22a9364521..ffa6a9fef5 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "playwright": { "chromium_revision": "724623", "firefox_revision": "1008", - "webkit_revision": "1044" + "webkit_revision": "1046" }, "scripts": { "unit": "node test/test.js", diff --git a/test/navigation.spec.js b/test/navigation.spec.js index b5727a124e..ce0d8eecb2 100644 --- a/test/navigation.spec.js +++ b/test/navigation.spec.js @@ -141,10 +141,9 @@ module.exports.addTests = function({testRunner, expect, playwright, FFOX, CHROME const response = await page.goto(server.EMPTY_PAGE, {waitUntil: 'networkidle2'}); expect(response.status()).toBe(200); }); - it.skip(WEBKIT)('should fail when navigating to bad url', async({page, server}) => { + it('should fail when navigating to bad url', async({page, server}) => { let error = null; await page.goto('asdfasdf').catch(e => error = e); - // FIXME: shows dialog in WebKit. if (CHROME || WEBKIT) expect(error.message).toContain('Cannot navigate to invalid URL'); else