diff --git a/packages/playwright-core/src/protocol/validator.ts b/packages/playwright-core/src/protocol/validator.ts index 0ccc146698..85f349c5fe 100644 --- a/packages/playwright-core/src/protocol/validator.ts +++ b/packages/playwright-core/src/protocol/validator.ts @@ -1586,7 +1586,6 @@ scheme.FrameExpectParams = tObject({ expectedText: tOptional(tArray(tType('ExpectedTextValue'))), expectedNumber: tOptional(tNumber), expectedValue: tOptional(tType('SerializedArgument')), - viewportRatio: tOptional(tNumber), useInnerText: tOptional(tBoolean), isNot: tBoolean, timeout: tOptional(tNumber), diff --git a/packages/playwright-core/src/server/injected/injectedScript.ts b/packages/playwright-core/src/server/injected/injectedScript.ts index e8bd7bb003..9c6dabb652 100644 --- a/packages/playwright-core/src/server/injected/injectedScript.ts +++ b/packages/playwright-core/src/server/injected/injectedScript.ts @@ -1191,7 +1191,7 @@ export class InjectedScript { // Viewport intersection if (expression === 'to.be.in.viewport') { const ratio = await this.viewportRatio(element); - return { received: `viewport ratio ${ratio}`, matches: ratio > 0 && ratio > (options.viewportRatio ?? 0) - 1e-9 }; + return { received: `viewport ratio ${ratio}`, matches: ratio > 0 && ratio > (options.expectedNumber ?? 0) - 1e-9 }; } } diff --git a/packages/playwright-test/src/matchers/matchers.ts b/packages/playwright-test/src/matchers/matchers.ts index 9337b12d44..9d80a038b7 100644 --- a/packages/playwright-test/src/matchers/matchers.ts +++ b/packages/playwright-test/src/matchers/matchers.ts @@ -125,7 +125,7 @@ export function toBeInViewport( options?: { timeout?: number, ratio?: number }, ) { return toBeTruthy.call(this, 'toBeInViewport', locator, 'Locator', async (isNot, timeout, customStackTrace) => { - return await locator._expect(customStackTrace, 'to.be.in.viewport', { isNot, viewportRatio: options?.ratio, timeout }); + return await locator._expect(customStackTrace, 'to.be.in.viewport', { isNot, expectedNumber: options?.ratio, timeout }); }, options); } diff --git a/packages/protocol/src/channels.ts b/packages/protocol/src/channels.ts index cb6f9e8ce9..3e75809e84 100644 --- a/packages/protocol/src/channels.ts +++ b/packages/protocol/src/channels.ts @@ -2844,7 +2844,6 @@ export type FrameExpectParams = { expectedText?: ExpectedTextValue[], expectedNumber?: number, expectedValue?: SerializedArgument, - viewportRatio?: number, useInnerText?: boolean, isNot: boolean, timeout?: number, @@ -2854,7 +2853,6 @@ export type FrameExpectOptions = { expectedText?: ExpectedTextValue[], expectedNumber?: number, expectedValue?: SerializedArgument, - viewportRatio?: number, useInnerText?: boolean, timeout?: number, }; diff --git a/packages/protocol/src/protocol.yml b/packages/protocol/src/protocol.yml index 34d2bc1f1b..0551af5876 100644 --- a/packages/protocol/src/protocol.yml +++ b/packages/protocol/src/protocol.yml @@ -2144,7 +2144,6 @@ Frame: items: ExpectedTextValue expectedNumber: number? expectedValue: SerializedArgument? - viewportRatio: number? useInnerText: boolean? isNot: boolean timeout: number?