From a8dbc0fdd8407ba5b50adb40b37e2b65a8df4d3d Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Fri, 8 Nov 2024 13:42:12 +0100 Subject: [PATCH] add special case for vscode instead --- packages/trace-viewer/src/sw/main.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/trace-viewer/src/sw/main.ts b/packages/trace-viewer/src/sw/main.ts index 27c966f29a..e8a746c23f 100644 --- a/packages/trace-viewer/src/sw/main.ts +++ b/packages/trace-viewer/src/sw/main.ts @@ -113,8 +113,10 @@ async function doFetch(event: FetchEvent): Promise { } if (!client) { - // expected client to be defined for all non-iframe requests. something went wrong - return fetch(event.request); + // vscode webview doesn't sent clientId under some circumstances + if (url.pathname.endsWith('embedded.html')) + return fetch(event.request); + throw new Error('expected client to be defined for all non-iframe requests. something went wrong'); } if (relativePath === '/contexts') {