Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: use old screencast protocol calls for Mac 10.14 (#6440)

Browse source 
This is a quick workaround to be cherry-picked in the release branch.
We'll align protocols in a follow-up.

References #6439
This commit is contained in:
Andrey Lushnikov 2021-05-06 10:38:46 -07:00 committed by GitHub
parent 7906a8f2f5
commit aab602cc3b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/server/webkit/wkPage.ts
View file

@ -19,6 +19,7 @@ import * as jpeg from 'jpeg-js';
import path from 'path'; import path from 'path';
import * as png from 'pngjs'; import * as png from 'pngjs';
import { splitErrorMessage } from '../../utils/stackTrace'; import { splitErrorMessage } from '../../utils/stackTrace';
import { hostPlatform } from '../../utils/registry';
import { assert, createGuid, debugAssert, headersArrayToObject, headersObjectToArray } from '../../utils/utils'; import { assert, createGuid, debugAssert, headersArrayToObject, headersObjectToArray } from '../../utils/utils';
import * as accessibility from '../accessibility'; import * as accessibility from '../accessibility';
import * as dialog from '../dialog'; import * as dialog from '../dialog';
@ -737,7 +738,8 @@ export class WKPage implements PageDelegate {
async _startScreencast(options: types.PageScreencastOptions): Promise<void> { async _startScreencast(options: types.PageScreencastOptions): Promise<void> {
assert(!this._recordingVideoFile); assert(!this._recordingVideoFile);
const { screencastId } = await this._pageProxySession.send('Screencast.startVideo', { const START_VIDEO_PROTOCOL_COMMAND = hostPlatform === 'mac10.14' ? 'Screencast.start' : 'Screencast.startVideo';
const { screencastId } = await this._pageProxySession.send(START_VIDEO_PROTOCOL_COMMAND as any, {
file: options.outputFile, file: options.outputFile,
width: options.width, width: options.width,
height: options.height, height: options.height,
@ -749,7 +751,8 @@ export class WKPage implements PageDelegate {
async _stopScreencast(): Promise<void> { async _stopScreencast(): Promise<void> {
if (!this._recordingVideoFile) if (!this._recordingVideoFile)
return; return;
await this._pageProxySession.sendMayFail('Screencast.stopVideo'); const STOP_VIDEO_PROTOCOL_COMMAND = hostPlatform === 'mac10.14' ? 'Screencast.stop' : 'Screencast.stopVideo';
await this._pageProxySession.sendMayFail(STOP_VIDEO_PROTOCOL_COMMAND as any);
this._recordingVideoFile = null; this._recordingVideoFile = null;
} }