Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: update "page.goBack should work for file urls" to match status quo (#16810)

Browse source 
Chromium works correctly, WebKit mac has a security error, Firefox fails to go back.
This commit is contained in:
Dmitry Gozman 2022-08-26 08:56:31 -07:00 committed by GitHub
parent fa234f4611
commit aac9df0542
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/assets/consolelog.html
View file

@ -5,7 +5,7 @@
</head> </head>
<body> <body>
<script> <script>
console.log('yellow') console.log('here:' + location.href)
</script> </script>
</body> </body>
</html> </html>

2
tests/page/page-event-console.spec.ts
View file

@ -138,7 +138,7 @@ it('should trigger correct Log', async ({ page, server, browserName, isWindows }
it('should have location for console API calls', async ({ page, server }) => { it('should have location for console API calls', async ({ page, server }) => {
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
const [message] = await Promise.all([ const [message] = await Promise.all([
page.waitForEvent('console', m => m.text() === 'yellow'), page.waitForEvent('console', m => m.text().startsWith('here:')),
page.goto(server.PREFIX + '/consolelog.html'), page.goto(server.PREFIX + '/consolelog.html'),
]); ]);
expect(message.type()).toBe('log'); expect(message.type()).toBe('log');

28
tests/page/page-history.spec.ts
View file

@ -53,20 +53,29 @@ it('page.goBack should work with HistoryAPI', async ({ page, server }) => {
}); });
it('page.goBack should work for file urls', async ({ page, server, asset, browserName, platform, isAndroid }) => { it('page.goBack should work for file urls', async ({ page, server, asset, browserName, platform, isAndroid }) => {
it.fail(browserName === 'webkit' && platform === 'darwin'); it.fixme(browserName === 'firefox', 'Firefox pretends, but does not complete goBack to the file url');
it.fail(browserName === 'webkit' && platform === 'darwin', 'WebKit embedder fails to go back/forward to the file url.');
it.skip(isAndroid, 'No files on Android'); it.skip(isAndroid, 'No files on Android');
// WebKit embedder fails to go back/forward to the file url. const url1 = url.pathToFileURL(asset('consolelog.html')).href;
const url1 = url.pathToFileURL(asset('empty.html')).href; const url2 = server.PREFIX + '/consolelog.html';
const url2 = server.EMPTY_PAGE; await Promise.all([
await page.goto(url1); page.waitForEvent('console', message => message.text() === 'here:' + url1),
page.goto(url1),
]);
await page.setContent(`<a href='${url2}'>url2</a>`); await page.setContent(`<a href='${url2}'>url2</a>`);
expect(page.url().toLowerCase()).toBe(url1.toLowerCase()); expect(page.url().toLowerCase()).toBe(url1.toLowerCase());
await page.click('a'); await Promise.all([
page.waitForEvent('console', message => message.text() === 'here:' + url2),
page.click('a'),
]);
expect(page.url()).toBe(url2); expect(page.url()).toBe(url2);
await page.goBack(); await Promise.all([
page.waitForEvent('console', message => message.text() === 'here:' + url1),
page.goBack(),
]);
expect(page.url().toLowerCase()).toBe(url1.toLowerCase()); expect(page.url().toLowerCase()).toBe(url1.toLowerCase());
// Should be able to evaluate in the new context, and // Should be able to evaluate in the new context, and
// not reach for the old cross-process one. // not reach for the old cross-process one.
@ -74,7 +83,10 @@ it('page.goBack should work for file urls', async ({ page, server, asset, browse
// Should be able to screenshot. // Should be able to screenshot.
await page.screenshot(); await page.screenshot();
await page.goForward(); await Promise.all([
page.waitForEvent('console', message => message.text() === 'here:' + url2),
page.goForward(),
]);
expect(page.url()).toBe(url2); expect(page.url()).toBe(url2);
expect(await page.evaluate(() => window.scrollX)).toBe(0); expect(await page.evaluate(() => window.scrollX)).toBe(0);
await page.screenshot(); await page.screenshot();