From ab63063c033b581e9d15daaa177fcb483f254576 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Mon, 14 Dec 2020 13:31:55 -0800 Subject: [PATCH] fix(tracing): store relative video path in the trace (#4710) --- src/trace/tracer.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/trace/tracer.ts b/src/trace/tracer.ts index 03561b9a18..54d818aeae 100644 --- a/src/trace/tracer.ts +++ b/src/trace/tracer.ts @@ -77,10 +77,12 @@ class ContextTracer implements SnapshotterDelegate, ActionListener { private _eventListeners: RegisteredListener[]; private _disposed = false; private _pageToId = new Map(); + private _traceFile: string; constructor(context: BrowserContext, traceStorageDir: string, traceFile: string) { this._context = context; this._contextId = 'context@' + createGuid(); + this._traceFile = traceFile; this._traceStoragePromise = mkdirIfNeeded(path.join(traceStorageDir, 'sha1')).then(() => traceStorageDir); this._appendEventChain = mkdirIfNeeded(traceFile).then(() => traceFile); this._writeArtifactChain = Promise.resolve(); @@ -162,7 +164,7 @@ class ContextTracer implements SnapshotterDelegate, ActionListener { type: 'page-video', contextId: this._contextId, pageId, - fileName: path.basename(video._path), + fileName: path.relative(path.dirname(this._traceFile), video._path), }; this._appendTraceEvent(event); });