Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(bidi): Avoid errors if url is unavailable in navigationStarted event

Browse source
This commit is contained in:
Julian Descottes 2025-01-10 19:14:11 +01:00
parent 13bdd3c92f
commit ac116248f9
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/playwright-core/src/server/bidi/bidiPage.ts
View file

@ -180,6 +180,12 @@ export class BidiPage implements PageDelegate {
const frameId = params.context; const frameId = params.context;
this._page._frameManager.frameRequestedNavigation(frameId, params.navigation!); this._page._frameManager.frameRequestedNavigation(frameId, params.navigation!);
// url is missing from navigationStarted events on Firefox when the
// navigation is interrupted by a beforeunload prompt.
// See https://bugzilla.mozilla.org/show_bug.cgi?id=1908952
if (!params.url)
return;
const url = params.url.toLowerCase(); const url = params.url.toLowerCase();
if (url.startsWith('file:') || url.startsWith('data:') || url === 'about:blank') { if (url.startsWith('file:') || url.startsWith('data:') || url === 'about:blank') {
// Navigation to file urls doesn't emit network events, so we fire 'commit' event right when navigation is started. // Navigation to file urls doesn't emit network events, so we fire 'commit' event right when navigation is started.