From ac395ac7949cbd2797da0427a14ed6298b9490f1 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Fri, 3 Jan 2025 14:44:44 +0100 Subject: [PATCH] fix: ipv4 detection on node 18 --- packages/playwright-core/src/utils/httpServer.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/utils/httpServer.ts b/packages/playwright-core/src/utils/httpServer.ts index 8da2a0e0d0..7311aa1c1a 100644 --- a/packages/playwright-core/src/utils/httpServer.ts +++ b/packages/playwright-core/src/utils/httpServer.ts @@ -128,7 +128,8 @@ export class HttpServer { this._urlPrefixHumanReadable = address; } else { this._port = address.port; - const resolvedHost = address.family === 'IPv4' ? address.address : `[${address.address}]`; + const isIPV4 = address.family === 'IPv4' || (address.family as any) === 4; // Node 18.0.0 returns number, >18.4.0 returns string + const resolvedHost = isIPV4 ? address.address : `[${address.address}]`; this._urlPrefixPrecise = `http://${resolvedHost}:${address.port}`; this._urlPrefixHumanReadable = `http://${host}:${address.port}`; }