Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: mark as flaky according to the new policy (#1322)

Browse source 
Closes #1300, #1303, #1305
This commit is contained in:
Andrey Lushnikov 2020-03-10 12:56:18 -07:00 committed by GitHub
parent 23cf3be828
commit ac5b518bea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/browsercontext.spec.js
View file

@ -20,7 +20,7 @@ const utils = require('./utils');
/** /**
* @type {BrowserTestSuite} * @type {BrowserTestSuite}
*/ */
module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FFOX, WEBKIT}) { module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FFOX, WEBKIT, LINUX}) {
const {describe, xdescribe, fdescribe} = testRunner; const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit, dit} = testRunner; const {it, fit, xit, dit} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
@ -420,8 +420,8 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FF
expect(response.status()).toBe(200); expect(response.status()).toBe(200);
await context.close(); await context.close();
}); });
// flaky: https://github.com/microsoft/playwright/issues/1303 // flaky: https://github.com/microsoft/playwright/pull/1301/checks?check_run_id=496478707
it.fail(FFOX)('should fail if wrong credentials', async({browser, server}) => { it.fail(FFOX && LINUX)('should fail if wrong credentials', async({browser, server}) => {
server.setAuth('/empty.html', 'user', 'pass'); server.setAuth('/empty.html', 'user', 'pass');
const context = await browser.newContext({ const context = await browser.newContext({
httpCredentials: { username: 'foo', password: 'bar' } httpCredentials: { username: 'foo', password: 'bar' }

6
test/evaluation.spec.js
View file

@ -22,7 +22,7 @@ const bigint = typeof BigInt !== 'undefined';
/** /**
* @type {PageTestSuite} * @type {PageTestSuite}
*/ */
module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) { module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, LINUX}) {
const {describe, xdescribe, fdescribe} = testRunner; const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit, dit} = testRunner; const {it, fit, xit, dit} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
@ -230,8 +230,8 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
await page.evaluate(e => e.textContent, element).catch(e => error = e); await page.evaluate(e => e.textContent, element).catch(e => error = e);
expect(error.message).toContain('JSHandle is disposed'); expect(error.message).toContain('JSHandle is disposed');
}); });
it.fail(FFOX)('should simulate a user gesture', async({page, server}) => { // flaky: https://github.com/microsoft/playwright/pull/1277/checks?check_run_id=496501774
// Flaky on Limux: https://github.com/microsoft/playwright/issues/1305 it.fail(FFOX && LINUX)('should simulate a user gesture', async({page, server}) => {
const result = await page.evaluate(() => { const result = await page.evaluate(() => {
document.body.appendChild(document.createTextNode('test')); document.body.appendChild(document.createTextNode('test'));
document.execCommand('selectAll'); document.execCommand('selectAll');

10
test/workers.spec.js
View file

@ -21,14 +21,14 @@ const { waitEvent } = utils;
/** /**
* @type {PageTestSuite} * @type {PageTestSuite}
*/ */
module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) { module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, LINUX}) {
const {describe, xdescribe, fdescribe} = testRunner; const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit, dit} = testRunner; const {it, fit, xit, dit} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
describe('Workers', function() { describe('Workers', function() {
// Flaky: https://github.com/microsoft/playwright/issues/1300 // flaky: https://github.com/microsoft/playwright/pull/1297/checks?check_run_id=496348690
it.fail(FFOX)('Page.workers', async function({page, server}) { it.fail(FFOX && LINUX)('Page.workers', async function({page, server}) {
await Promise.all([ await Promise.all([
page.waitForEvent('worker'), page.waitForEvent('worker'),
page.goto(server.PREFIX + '/worker/worker.html')]); page.goto(server.PREFIX + '/worker/worker.html')]);
@ -102,8 +102,8 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
expect(destroyed).toBe(true); expect(destroyed).toBe(true);
expect(page.workers().length).toBe(0); expect(page.workers().length).toBe(0);
}); });
// Flaky: https://github.com/microsoft/playwright/issues/1300 // flaky: https://github.com/microsoft/playwright/pull/1277/checks?check_run_id=496461538
it.fail(FFOX)('should report network activity', async function({page, server}) { it.fail(FFOX && LINUX)('should report network activity', async function({page, server}) {
const [worker] = await Promise.all([ const [worker] = await Promise.all([
page.waitForEvent('worker'), page.waitForEvent('worker'),
page.goto(server.PREFIX + '/worker/worker.html'), page.goto(server.PREFIX + '/worker/worker.html'),