Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unskip selenium driver test (#23129)

Browse source 
Issue is that [when `stop()` is
called](28504f6dc7/tests/library/browsertype-launch-selenium.spec.ts (L202)),
`onExit()` gets called and then it throws an unhandled rejection.

This regressed in https://github.com/microsoft/playwright/pull/23028.

I didn't find a reason to keep onExit, so removed it for now since
transport should handle these scenarios.

Fixes https://github.com/microsoft/playwright/issues/23110
This commit is contained in:
Max Schmitt 2023-05-18 18:33:11 +02:00 committed by GitHub
parent 0c032eb7be
commit acdb71878e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/playwright-core/src/outofprocess.ts
View file

@ -43,7 +43,6 @@ class PlaywrightClient {
}, },
}); });
this._driverProcess.unref(); this._driverProcess.unref();
this._driverProcess.on('exit', this._onExit.bind(this));
const connection = new Connection(); const connection = new Connection();
connection.markAsRemote(); connection.markAsRemote();
@ -56,14 +55,9 @@ class PlaywrightClient {
} }
async stop() { async stop() {
this._driverProcess.removeListener('exit', this._onExit);
this._driverProcess.stdin!.destroy(); this._driverProcess.stdin!.destroy();
this._driverProcess.stdout!.destroy(); this._driverProcess.stdout!.destroy();
this._driverProcess.stderr!.destroy(); this._driverProcess.stderr!.destroy();
await this._closePromise; await this._closePromise;
} }
private _onExit(exitCode: number | null, signal: string | null) {
throw new Error(`Server closed with exitCode=${exitCode} signal=${signal}`);
}
} }

1
tests/library/browsertype-launch-selenium.spec.ts
View file

@ -180,7 +180,6 @@ test('selenium grid 3.141.59 standalone non-chromium', async ({ browserName, bro
test('selenium grid 3.141.59 standalone chromium through run-driver', async ({ browserName, childProcess, waitForPort }, testInfo) => { test('selenium grid 3.141.59 standalone chromium through run-driver', async ({ browserName, childProcess, waitForPort }, testInfo) => {
test.skip(browserName !== 'chromium'); test.skip(browserName !== 'chromium');
test.fixme(true, 'https://github.com/microsoft/playwright/issues/23110');
const port = testInfo.workerIndex + 15123; const port = testInfo.workerIndex + 15123;
const grid = childProcess({ const grid = childProcess({