From ad6d24bf94e453632ecf8a5398d70a4edf1124e0 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Thu, 26 Jan 2023 19:01:54 -0800 Subject: [PATCH] test: update headful.spec to use modern fixtures (#20428) --- tests/library/headful.spec.ts | 76 ++++++++++++++--------------------- 1 file changed, 31 insertions(+), 45 deletions(-) diff --git a/tests/library/headful.spec.ts b/tests/library/headful.spec.ts index ce17a4ed3c..7211fe6609 100644 --- a/tests/library/headful.spec.ts +++ b/tests/library/headful.spec.ts @@ -18,28 +18,27 @@ import { compare } from 'playwright-core/lib/image_tools/compare'; import { PNG } from 'playwright-core/lib/utilsBundle'; import { expect, playwrightTest as it } from '../config/browserTest'; -it('should have default url when launching browser @smoke', async ({ browserType, createUserDataDir }) => { - const browserContext = await browserType.launchPersistentContext(await createUserDataDir(), { headless: false }); - const urls = browserContext.pages().map(page => page.url()); +it.use({ headless: false }); + +it('should have default url when launching browser @smoke', async ({ launchPersistent }) => { + const { context } = await launchPersistent(); + const urls = context.pages().map(page => page.url()); expect(urls).toEqual(['about:blank']); - await browserContext.close(); }); -it('should close browser with beforeunload page', async ({ browserType, server, createUserDataDir }) => { +it('should close browser with beforeunload page', async ({ launchPersistent, server }) => { it.slow(); - const browserContext = await browserType.launchPersistentContext(await createUserDataDir(), { headless: false }); - const page = await browserContext.newPage(); + const { context } = await launchPersistent(); + const page = await context.newPage(); await page.goto(server.PREFIX + '/beforeunload.html'); // We have to interact with a page so that 'beforeunload' handlers // fire. await page.click('body'); - await browserContext.close(); + await context.close(); }); -it('should close browsercontext with pending beforeunload dialog', async ({ server, browserType }) => { - const browser = await browserType.launch({ headless: false }); - const context = await browser.newContext(); +it('should close browsercontext with pending beforeunload dialog', async ({ server, context }) => { const page = await context.newPage(); await page.goto(server.PREFIX + '/beforeunload.html'); // We have to interact with a page so that 'beforeunload' handlers @@ -50,12 +49,10 @@ it('should close browsercontext with pending beforeunload dialog', async ({ serv page.close({ runBeforeUnload: true }), ]); await context.close(); - await browser.close(); }); -it('should not crash when creating second context', async ({ browserType }) => { - const browser = await browserType.launch({ headless: false }); +it('should not crash when creating second context', async ({ browser }) => { { const browserContext = await browser.newContext(); await browserContext.newPage(); @@ -66,29 +63,23 @@ it('should not crash when creating second context', async ({ browserType }) => { await browserContext.newPage(); await browserContext.close(); } - await browser.close(); }); -it('should click background tab', async ({ browserType, server }) => { - const browser = await browserType.launch({ headless: false }); - const page = await browser.newPage(); +it('should click background tab', async ({ page, server }) => { await page.setContent(`empty.html`); await page.click('a'); await page.click('button'); - await browser.close(); }); it('should close browser after context menu was triggered', async ({ browserType, server }) => { - const browser = await browserType.launch({ headless: false }); + const browser = await browserType.launch(); const page = await browser.newPage(); await page.goto(server.PREFIX + '/grid.html'); await page.click('body', { button: 'right' }); await browser.close(); }); -it('should(not) block third party cookies', async ({ browserType, server, browserName, allowsThirdParty }) => { - const browser = await browserType.launch({ headless: false }); - const page = await browser.newPage(); +it('should(not) block third party cookies', async ({ page, server, allowsThirdParty }) => { await page.goto(server.EMPTY_PAGE); await page.evaluate(src => { let fulfill; @@ -122,12 +113,10 @@ it('should(not) block third party cookies', async ({ browserType, server, browse } else { expect(cookies).toEqual([]); } - await browser.close(); }); -it('should not block third party SameSite=None cookies', async ({ httpsServer, browserName, browserType }) => { +it('should not block third party SameSite=None cookies', async ({ httpsServer, browserName, browser }) => { it.skip(browserName === 'webkit', 'No third party cookies in WebKit'); - const browser = await browserType.launch({ headless: false }); const page = await browser.newPage({ ignoreHTTPSErrors: true, }); @@ -159,14 +148,13 @@ it('should not block third party SameSite=None cookies', async ({ httpsServer, b await page.goto(httpsServer.EMPTY_PAGE); expect(await cookie).toBe('a=b'); - await browser.close(); + await page.close(); }); -it('should not override viewport size when passed null', async function({ browserType, server, browserName }) { +it('should not override viewport size when passed null', async function({ browserName, server, browser }) { it.fixme(browserName === 'webkit'); // Our WebKit embedder does not respect window features. - const browser = await browserType.launch({ headless: false }); const context = await browser.newContext({ viewport: null }); const page = await context.newPage(); await page.goto(server.EMPTY_PAGE); @@ -180,11 +168,9 @@ it('should not override viewport size when passed null', async function({ browse await popup.waitForLoadState(); await popup.waitForFunction(() => window.outerWidth === 500 && window.outerHeight === 450); await context.close(); - await browser.close(); }); -it('Page.bringToFront should work', async ({ browserType }) => { - const browser = await browserType.launch({ headless: false }); +it('Page.bringToFront should work', async ({ browser }) => { const page1 = await browser.newPage(); await page1.setContent('Page1'); const page2 = await browser.newPage(); @@ -199,10 +185,12 @@ it('Page.bringToFront should work', async ({ browserType }) => { expect(await page2.evaluate('document.visibilityState')).toBe( 'visible' ); - await browser.close(); + + await page1.close(); + await page2.close(); }); -it.skip('should click in OOPIF', async ({ browserName, browserType, createUserDataDir, server }) => { +it.skip('should click in OOPIF', async ({ browserName, launchPersistent, server }) => { it.fixme(browserName === 'chromium'); server.setRoute('/empty.html', (req, res) => { res.writeHead(200, { 'Content-Type': 'text/html' }); @@ -214,8 +202,7 @@ it.skip('should click in OOPIF', async ({ browserName, browserType, createUserDa `); }); - const context = await browserType.launchPersistentContext(await createUserDataDir(), { headless: false }); - const [page] = context.pages(); + const { page } = await launchPersistent(); const consoleLog: string[] = []; page.on('console', m => consoleLog.push(m.text())); await page.goto(server.EMPTY_PAGE); @@ -223,7 +210,7 @@ it.skip('should click in OOPIF', async ({ browserName, browserType, createUserDa expect(consoleLog).toContain('ok'); }); -it.skip('should click bottom row w/ infobar in OOPIF', async ({ browserType, createUserDataDir, server }) => { +it.skip('should click bottom row w/ infobar in OOPIF', async ({ launchPersistent, server }) => { server.setRoute('/empty.html', (req, res) => { res.writeHead(200, { 'Content-Type': 'text/html' }); res.end(` @@ -245,8 +232,7 @@ it.skip('should click bottom row w/ infobar in OOPIF', async ({ browserType, cre `); }); - const browserContext = await browserType.launchPersistentContext(await createUserDataDir(), { headless: false }); - const [page] = browserContext.pages(); + const { page } = await launchPersistent(); await page.goto(server.EMPTY_PAGE); // Chrome bug! Investigate what's happening in the oopif router. const consoleLog: string[] = []; @@ -257,7 +243,7 @@ it.skip('should click bottom row w/ infobar in OOPIF', async ({ browserType, cre } }); -it('headless and headful should use same default fonts', async ({ page, headless, browserName, browserType, platform }) => { +it('headless and headful should use same default fonts', async ({ page, browserName, browserType }) => { it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/11177' }); it.fixme(browserName === 'firefox', 'Text is misaligned in headed vs headless'); const genericFontFamilies = [ @@ -269,19 +255,19 @@ it('headless and headful should use same default fonts', async ({ page, headless 'fantasy', 'emoji' ]; - const headedBrowser = await browserType.launch({ headless: !headless }); - const headedPage = await headedBrowser.newPage(); + const headlessBrowser = await browserType.launch({ headless: true }); + const headlessPage = await headlessBrowser.newPage(); for (const family of genericFontFamilies) { const content = `
Lorem ipsum dolor sit amet consectetur adipiscing elit proin, integer curabitur imperdiet rhoncus cursus tincidunt bibendum, consequat sed magnis laoreet luctus mollis tellus. Nisl parturient mus accumsan feugiat sem laoreet magnis nisi, aptent per sollicitudin gravida orci ac blandit, viverra eros praesent auctor vivamus semper bibendum. Consequat sed habitasse luctus dictumst gravida platea semper phasellus, nascetur ridiculus purus est varius quisque et scelerisque, id vehicula eleifend montes sollicitudin dis velit. Pellentesque ridiculus per natoque et eleifend taciti nunc, laoreet auctor at condimentum imperdiet ante, conubia mi cubilia scelerisque sociosqu sem.

Curabitur magna per felis primis mauris non dapibus luctus ultricies eros, quis et egestas condimentum lobortis eget semper montes litora purus, ridiculus elementum sollicitudin imperdiet dictum lacinia parturient cras eu. Risus cum varius rhoncus eros torquent pretium taciti id erat dis egestas, nibh tristique montes convallis metus lacus phasellus blandit ut auctor bibendum semper, facilisis mi integer eget ultrices lobortis odio viverra duis dui. Risus ullamcorper lacinia in venenatis sodales fusce tortor potenti volutpat quis, dictum vulputate suspendisse velit mollis torquent sociis aptent morbi, senectus nascetur justo maecenas conubia magnis viverra gravida fames. Phasellus sed nec gravida nibh class augue lectus, blandit quis turpis orci diam nam pellentesque, ultricies metus imperdiet hendrerit lacinia lacus.

Inceptos facilisi montes cum hendrerit, pulvinar ut tellus eget velit, arcu nulla aenean. Phasellus augue urna nostra molestie interdum vehicula, posuere fames cum euismod massa curabitur donec, inceptos cubilia tellus facilisis fermentum. Lacus laoreet facilisis ultrices cursus quisque at ad porta vestibulum massa inceptos, curae class aliquet maecenas cum ullamcorper pulvinar erat mus vitae. Cum in aenean convallis dis quam tincidunt justo sed quisque, imperdiet faucibus hendrerit felis commodo scelerisque magnis vehicula etiam leo, eros varius platea lobortis maecenas condimentum nisi phasellus. Turpis vulputate mus himenaeos sociosqu facilisis dignissim leo quam, ultricies habitasse commodo molestie est tortor vitae et, porttitor risus erat cursus phasellus facilisi litora.

Nostra habitasse egestas magnis velit pellentesque parturient cum lectus viverra, vestibulum sociosqu nunc vel urna consequat lacinia phasellus at sapien, aenean pretium dictum sed montes interdum imperdiet iaculis. Leo hac eros arcu senectus maecenas, tortor pulvinar venenatis lacinia volutpat, mattis platea ut facilisi. Aenean condimentum at et donec sociosqu fermentum luctus potenti semper vulputate, sapien justo non est auctor gravida ultricies fames per commodo, sed habitasse facilisi nulla quisque hendrerit aliquet viverra bibendum.

Interdum nisl quam etiam montes porttitor laoreet nullam senectus velit, mauris proin tellus imperdiet litora venenatis fames massa quis, sollicitudin justo vivamus curae in sociis suscipit facilisi. Platea inceptos lacus elementum pellentesque quam euismod dictumst sociis tincidunt vulputate porttitor eros, turpis netus ut ad tempor sapien aliquet sodales molestie consequat nostra. Cum augue in quisque primis ut nunc sodales, sem orci tempus posuere cubilia suspendisse lacinia ligula, magna sed ridiculus at maecenas habitant.

Natoque magna ac feugiat tellus bibendum diam, metus lobortis nisl ornare varius praesent, dictumst gravida lacus parturient semper. Pellentesque faucibus congue fusce posuere placerat dictum vitae, dui vestibulum eu sociis tempus aliquam ultricies malesuada, potenti laoreet lacus sem gravida nisi. Nostra platea sagittis hendrerit congue conubia senectus bibendum quis sapien pharetra, scelerisque nam imperdiet fermentum feugiat suspendisse viverra luctus at, semper ac consequat vitae mi gravida parturient mollis nascetur. Vel taciti justo consequat primis et blandit convallis sed, felis purus fusce a venenatis etiam aenean scelerisque, fringilla volutpat sagittis egestas rutrum id dis.

Feugiat fermentum tortor ante ac iaculis sollicitudin ut interdum, cras orci ullamcorper potenti tristique vehicula. Molestie tortor ullamcorper rutrum turpis malesuada phasellus sem ultricies praesent mattis lobortis porta, senectus venenatis diam nostra laoreet volutpat per aptent justo elementum cum. Urna cursus vel felis cras eleifend arcu enim magnis, duis rutrum nibh nascetur cubilia interdum ultrices curae, id lacus aliquam dictumst diam fringilla lacinia.

Luctus diam morbi eget tellus libero taciti faucibus inceptos, natoque facilisis lectus maecenas risus dapibus suscipit nibh, vel curae conubia orci imperdiet metus fusce. Condimentum massa donec luctus pharetra cum, in viverra placerat nisl litora facilisis, neque nascetur sociis dictumst. Suscipit accumsan eget rhoncus pharetra justo malesuada aliquet, suspendisse metus eleifend tincidunt varius ridiculus, convallis primis vitae curabitur quis mus.

Gravida donec lacus molestie tortor aenean ultricies blandit per tempor, nostra penatibus orci vestibulum semper lectus vel a, montes potenti cum dapibus natoque eu volutpat nulla. Himenaeos purus nam malesuada habitasse nisl pharetra laoreet feugiat mi non, ultrices ultricies a cras ante eu venenatis ligula. Suscipit ut mus habitasse at aliquet sodales commodo justo, feugiat platea sagittis phasellus eleifend pellentesque interdum iaculis, integer cubilia montes metus hendrerit tincidunt purus.

Vel posuere tellus dapibus eget duis cubilia, nec class vehicula libero gravida ligula, tempus urna taciti donec congue. Facilisis ridiculus congue cum dui per augue natoque, molestie hac etiam pellentesque dignissim urna class, feugiat aenean massa himenaeos penatibus ut eu, convallis purus et fusce tempus mattis. At mattis suscipit porta nostra nec facilisis sodales turpis, integer et lectus conubia justo nam congue taciti odio, fermentum semper cubilia fusce nunc purus velit.

`; - await Promise.all([page.setContent(content), headedPage.setContent(content)]); + await Promise.all([page.setContent(content), headlessPage.setContent(content)]); const [image1, image2] = (await Promise.all([ - page.screenshot(), headedPage.screenshot() + page.screenshot(), headlessPage.screenshot() ])).map(buffer => PNG.sync.read(buffer)); const count = compare(image1.data, image2.data, null, image1.width, image2.height); expect(count).toBe(0); } - await headedBrowser.close(); + await headlessBrowser.close(); });