Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Update docs/src/best-practices-js.md

Browse source 
Signed-off-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Max Schmitt 2024-08-21 11:29:05 +02:00 committed by GitHub
parent d9710bf470
commit ad93424dd4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/src/best-practices-js.md
View file

@ -265,7 +265,7 @@ Use Linux when running your tests on CI as it is cheaper. Developers can use wha
### Lint your tests ### Lint your tests
Linting the tests helps catching errors early. Use [`@typescript-eslint/no-floating-promises`](https://typescript-eslint.io/rules/no-floating-promises/) [ESLint](https://eslint.org) rule to make sure there are no missing awaits before the asynchronous calls to the Playwright API. Also running `tsc --noEmit` in your CI ensures that functions are called with the right signature. We recommend TypeScript and linting witih ESLint for your tests to catch errors early. Use [`@typescript-eslint/no-floating-promises`](https://typescript-eslint.io/rules/no-floating-promises/) [ESLint](https://eslint.org) rule to make sure there are no missing awaits before the asynchronous calls to the Playwright API. On your CI you can run `tsc --noEmit` to ensure that functions are called with the right signature.
### Use parallelism and sharding ### Use parallelism and sharding