Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(codegen): fallback to iframe[name/src] when failed to generate selector

Browse source 
This could happen, for example, when iframe element is inside a closed
shadow root. Instead of using `error.toString()` as a selector (!),
fallback to `iframe[name]` or `iframe[src]`.
This commit is contained in:
Dmitry Gozman 2024-12-16 10:51:18 +00:00
parent f713d3adaf
commit ae3ffc2c3d
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/playwright-core/src/server/recorder/contextRecorder.ts
View file

@ -300,7 +300,6 @@ async function generateFrameSelectorInParent(parent: Frame, frame: Frame): Promi
}, frameElement); }, frameElement);
return selector; return selector;
} catch (e) { } catch (e) {
return e.toString();
} }
}, monotonicTime() + 2000); }, monotonicTime() + 2000);
if (!result.timedOut && result.result) if (!result.timedOut && result.result)