Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#17344): Revert "chore(generator): use new .NET test attributes (#17172)" (#17347)

Browse source 
This reverts commit 15add13a6a.
This commit is contained in:
Max Schmitt 2022-09-15 00:41:56 +02:00 committed by Andrey Lushnikov
parent 0bd44ef8ad
commit ae4c5bf125
10 changed files with 27 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
docs/src/api-testing-csharp.md
View file

@ -103,7 +103,7 @@ namespace PlaywrightTests
private IAPIRequestContext Request = null;
[PlaywrightTest]
[Test]
public async Task ShouldCreateBugReport()
{
var data = new Dictionary<string, string>();
@ -130,7 +130,7 @@ namespace PlaywrightTests
Assert.AreEqual("Bug description", issue?.GetProperty("body").GetString());
}
[PlaywrightTest]
[Test]
public async Task ShouldCreateFeatureRequests()
{
var data = new Dictionary<string, string>();
@ -229,7 +229,7 @@ namespace PlaywrightTests
private IAPIRequestContext Request = null;
[PlaywrightTest]
[Test]
public async Task ShouldCreateBugReport()
{
var data = new Dictionary<string, string>();
@ -256,7 +256,7 @@ namespace PlaywrightTests
Assert.AreEqual("Bug description", issue?.GetProperty("body").GetString());
}
[PlaywrightTest]
[Test]
public async Task ShouldCreateFeatureRequests()
{
var data = new Dictionary<string, string>();
@ -343,7 +343,7 @@ The following test creates a new issue via API and then navigates to the list of
project to check that it appears at the top of the list. The check is performed using [LocatorAssertions].
```csharp
[PlaywrightTest]
[Test]
public async Task LastCreatedIssueShouldBeFirstInTheList()
{
var data = new Dictionary<string, string>();
@ -366,7 +366,7 @@ The following test creates a new issue via user interface in the browser and the
it was created:
```csharp
[PlaywrightTest]
[Test]
public async Task LastCreatedIssueShouldBeOnTheServer()
{
await Page.GotoAsync("https://github.com/" + USER + "/" + REPO + "/issues");

2
docs/src/api/class-locatorassertions.md
View file

@ -57,7 +57,7 @@ namespace PlaywrightTests;
[TestFixture]
public class ExampleTests : PageTest
{
[PlaywrightTest]
[Test]
public async Task StatusBecomesSubmitted()
{
// ..

2
docs/src/api/class-pageassertions.md
View file

@ -59,7 +59,7 @@ namespace PlaywrightTests;
[TestFixture]
public class ExampleTests : PageTest
{
[PlaywrightTest]
[Test]
public async Task NavigatetoLoginPage()
{
// ..

2
docs/src/api/class-playwrightassertions.md
View file

@ -58,7 +58,7 @@ namespace PlaywrightTests;
[TestFixture]
public class ExampleTests : PageTest
{
[PlaywrightTest]
[Test]
public async Task StatusBecomesSubmitted()
{
await Page.Locator("#submit-button").ClickAsync();

4
docs/src/intro-csharp.md
View file

@ -101,7 +101,7 @@ namespace PlaywrightTests;
[TestFixture]
public class Tests : PageTest
{
[PlaywrightTest]
[Test]
public async Task HomepageHasPlaywrightInTitleAndGetStartedLinkLinkingtoTheIntroPage()
{
await Page.GotoAsync("https://playwright.dev");
@ -136,7 +136,7 @@ namespace PlaywrightTests;
[TestClass]
public class UnitTest1 : PageTest
{
[PlaywrightTestMethod]
[TestMethod]
public async Task HomepageHasPlaywrightInTitleAndGetStartedLinkLinkingtoTheIntroPage()
{
await Page.GotoAsync("https://playwright.dev");

2
docs/src/release-notes-csharp.md
View file

@ -263,7 +263,7 @@ namespace PlaywrightTests;
[TestFixture]
public class ExampleTests : PageTest
{
[PlaywrightTest]
[Test]
public async Task StatusBecomesSubmitted()
{
await Expect(Page.Locator(".status")).ToHaveTextAsync("Submitted");

16
docs/src/test-runners-csharp.md
View file

@ -44,14 +44,14 @@ namespace PlaywrightTests;
[TestFixture]
public class MyTest : PageTest
{
[PlaywrightTest]
[Test]
public async Task ShouldHaveTheCorrectSlogan()
{
await Page.GotoAsync("https://playwright.dev");
await Expect(Page.Locator("text=enables reliable end-to-end testing for modern web apps")).ToBeVisibleAsync();
}
[PlaywrightTest]
[Test]
public async Task ShouldHaveTheCorrectTitle()
{
await Page.GotoAsync("https://playwright.dev");
@ -125,7 +125,7 @@ namespace PlaywrightTests;
[TestFixture]
public class MyTest : PageTest
{
[PlaywrightTest]
[Test]
public async Task TestWithCustomContextOptions()
{
// The following Page (and BrowserContext) instance has the custom colorScheme, viewport and baseURL set:
@ -217,10 +217,6 @@ There are a few base classes available to you in `Microsoft.Playwright.NUnit` na
|BrowserTest |Each test will get a browser and can create as many contexts as it likes. Each test is responsible for cleaning up all the contexts it created.|
|PlaywrightTest|This gives each test a Playwright object so that the test could start and stop as many browsers as it likes.|
### 'No test is available'
You need to add `[TestFixture]` to your test class. NUnit does not discover tests without it, if the `TestAttribute` comes from a different assembly.
## MSTest
Playwright provides base classes to write tests with MSTest via the [`Microsoft.Playwright.MSTest`](https://www.nuget.org/packages/Microsoft.Playwright.MSTest) package.
@ -250,14 +246,14 @@ namespace PlaywrightTests;
[TestClass]
public class UnitTest1: PageTest
{
[PlaywrightTestMethod]
[TestMethod]
public async Task ShouldHaveTheCorrectSlogan()
{
await Page.GotoAsync("https://playwright.dev");
await Expect(Page.Locator("text=enables reliable end-to-end testing for modern web apps")).ToBeVisibleAsync();
}
[PlaywrightTestMethod]
[TestMethod]
public async Task ShouldHaveTheCorrectTitle()
{
await Page.GotoAsync("https://playwright.dev");
@ -335,7 +331,7 @@ namespace PlaywrightTests;
[TestClass]
public class UnitTest1 : PageTest
{
[PlaywrightTestMethod]
[TestMethod]
public async Task TestWithCustomContextOptions()
{
// The following Page (and BrowserContext) instance has the custom colorScheme, viewport and baseURL set:

12
docs/src/writing-tests-csharp.md
View file

@ -27,7 +27,7 @@ namespace PlaywrightTests;
[TestFixture]
public class Tests : PageTest
{
[PlaywrightTest]
[Test]
public async Task HomepageHasPlaywrightInTitleAndGetStartedLinkLinkingtoTheIntroPage()
{
await Page.GotoAsync("https://playwright.dev");
@ -62,7 +62,7 @@ namespace PlaywrightTests;
[TestClass]
public class UnitTest1 : PageTest
{
[PlaywrightTestMethod]
[TestMethod]
public async Task HomepageHasPlaywrightInTitleAndGetStartedLinkLinkingtoTheIntroPage()
{
await Page.GotoAsync("https://playwright.dev");
@ -140,7 +140,7 @@ namespace PlaywrightTests;
[TestFixture]
public class Tests : PageTest
{
[PlaywrightTest]
[Test]
public async Task BasicTest()
{
await Page.GotoAsync("https://playwright.dev");
@ -159,7 +159,7 @@ namespace PlaywrightTests;
[TestClass]
public class UnitTest1 : PageTest
{
[PlaywrightTestMethod]
[TestMethod]
public async Task BasicTest()
{
await Page.GotoAsync("https://playwright.dev");
@ -195,7 +195,7 @@ namespace PlaywrightTests;
[TestFixture]
public class Tests : PageTest
{
[PlaywrightTest]
[Test]
public async Task MainNavigation()
{
// Assertions use the expect API.
@ -221,7 +221,7 @@ namespace PlaywrightTests;
[TestClass]
public class UnitTest1 : PageTest
{
[PlaywrightTestMethod]
[TestMethod]
public async Task MainNavigation()
{
// Assertions use the expect API.

2
packages/playwright-core/src/server/recorder/csharp.ts
View file

@ -207,7 +207,7 @@ export class CSharpLanguageGenerator implements LanguageGenerator {
}`);
formatter.newLine();
}
formatter.add(` [${this._mode === 'nunit' ? 'PlaywrightTest' : 'PlaywrightTestMethod'}]
formatter.add(` [${this._mode === 'nunit' ? 'Test' : 'TestMethod'}]
public async Task MyTest()
{`);
return formatter.format();

4
tests/library/inspector/cli-codegen-csharp.spec.ts
View file

@ -232,7 +232,7 @@ public class Tests : PageTest
};
}
[PlaywrightTestMethod]
[TestMethod]
public async Task MyTest()
{
// Go to ${emptyHTML}
@ -261,7 +261,7 @@ public class Tests : PageTest
};
}
[PlaywrightTest]
[Test]
public async Task MyTest()
{
// Go to ${emptyHTML}