From ae7c52154fca922b0aa6bc5146c8a156d950372b Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Wed, 9 Feb 2022 15:25:15 -0800 Subject: [PATCH] fix(fixtures): make sure connected browser respects context options (#11990) Connected browser was wired up to the wrong browserType object. --- packages/playwright-core/src/client/browserType.ts | 2 +- tests/playwright-test/playwright.spec.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/client/browserType.ts b/packages/playwright-core/src/client/browserType.ts index f6d4259e42..07e86998cd 100644 --- a/packages/playwright-core/src/client/browserType.ts +++ b/packages/playwright-core/src/client/browserType.ts @@ -171,7 +171,7 @@ export class BrowserType extends ChannelOwner imple browser = Browser.from(playwright._initializer.preLaunchedBrowser!); browser._logger = logger; browser._shouldCloseConnectionOnClose = true; - browser._setBrowserType((playwright as any)[browser._name]); + browser._setBrowserType(this); browser._localUtils = this._playwright._utils; browser.on(Events.Browser.Disconnected, closePipe); return browser; diff --git a/tests/playwright-test/playwright.spec.ts b/tests/playwright-test/playwright.spec.ts index 6d9a95f8c7..ca217e010a 100644 --- a/tests/playwright-test/playwright.spec.ts +++ b/tests/playwright-test/playwright.spec.ts @@ -568,9 +568,11 @@ test('should work with connectOptions', async ({ runInlineTest }) => { `, 'a.test.ts': ` const { test } = pwt; + test.use({ locale: 'fr-CH' }); test('pass', async ({ page }) => { await page.setContent('
PASS
'); await expect(page.locator('div')).toHaveText('PASS'); + expect(await page.evaluate(() => navigator.language)).toBe('fr-CH'); }); `, });