From af48a8a1f140af59184f62dab2a7a9705e0f10b4 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Mon, 5 Apr 2021 21:39:15 +0200 Subject: [PATCH] devops: use ubuntu focal on bots and docs (#5951) - drive-by: updated NPM Action - replaced ubuntu-latest by ubuntu-20 so its pinned Extracted from #5746 --- .github/workflows/infra.yml | 6 ++-- .github/workflows/publish_canary_docker.yml | 2 +- .github/workflows/publish_canary_driver.yml | 2 +- .github/workflows/publish_canary_npm.yml | 4 +-- .github/workflows/publish_release.yml | 8 ++--- .github/workflows/tests.yml | 36 +++++++++---------- .github/workflows/trigger_build_chromium.yml | 2 +- ...gger_build_deprecated_webkit_mac_10.14.yml | 2 +- .github/workflows/trigger_build_ffmpeg.yml | 2 +- .github/workflows/trigger_build_firefox.yml | 2 +- .github/workflows/trigger_build_webkit.yml | 2 +- .github/workflows/trigger_build_winldd.yml | 2 +- .github/workflows/trigger_tests.yml | 2 +- docs/src/ci.md | 12 +++---- docs/src/docker.md | 2 +- 15 files changed, 42 insertions(+), 44 deletions(-) diff --git a/.github/workflows/infra.yml b/.github/workflows/infra.yml index 55b7f169fc..4a082cf6d7 100644 --- a/.github/workflows/infra.yml +++ b/.github/workflows/infra.yml @@ -13,10 +13,10 @@ on: jobs: doc-and-lint: name: "docs & lint" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - uses: microsoft/playwright-github-action@v1 @@ -36,7 +36,7 @@ jobs: runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - uses: microsoft/playwright-github-action@v1 diff --git a/.github/workflows/publish_canary_docker.yml b/.github/workflows/publish_canary_docker.yml index 89b4fb486c..b9399e57a5 100644 --- a/.github/workflows/publish_canary_docker.yml +++ b/.github/workflows/publish_canary_docker.yml @@ -24,7 +24,7 @@ jobs: username: playwright password: ${{ secrets.DOCKER_PASSWORD }} - uses: microsoft/playwright-github-action@v1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10.15 - run: npm ci diff --git a/.github/workflows/publish_canary_driver.yml b/.github/workflows/publish_canary_driver.yml index 96f118f23b..4342c97ee7 100644 --- a/.github/workflows/publish_canary_driver.yml +++ b/.github/workflows/publish_canary_driver.yml @@ -13,7 +13,7 @@ jobs: if: github.repository == 'microsoft/playwright' steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 12.x registry-url: 'https://registry.npmjs.org' diff --git a/.github/workflows/publish_canary_npm.yml b/.github/workflows/publish_canary_npm.yml index 535bd9f810..7a4a5e1551 100644 --- a/.github/workflows/publish_canary_npm.yml +++ b/.github/workflows/publish_canary_npm.yml @@ -10,11 +10,11 @@ on: jobs: publish-canary-npm: name: "publish to NPM" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 if: github.repository == 'microsoft/playwright' steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 registry-url: 'https://registry.npmjs.org' diff --git a/.github/workflows/publish_release.yml b/.github/workflows/publish_release.yml index 3c2b84c022..6f035d32a3 100644 --- a/.github/workflows/publish_release.yml +++ b/.github/workflows/publish_release.yml @@ -7,11 +7,11 @@ on: jobs: publish-npm-release: name: "publish to NPM" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 if: github.repository == 'microsoft/playwright' steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 registry-url: 'https://registry.npmjs.org' @@ -28,7 +28,7 @@ jobs: if: github.repository == 'microsoft/playwright' steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 12.x registry-url: 'https://registry.npmjs.org' @@ -55,7 +55,7 @@ jobs: username: playwright password: ${{ secrets.DOCKER_PASSWORD }} - uses: microsoft/playwright-github-action@v1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10.15 - run: npm ci diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index fa79f001cb..0bc7afe568 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -27,7 +27,7 @@ jobs: runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci @@ -59,7 +59,7 @@ jobs: runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci @@ -86,7 +86,7 @@ jobs: shell: powershell run: Install-WindowsFeature Server-Media-Foundation - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci @@ -104,7 +104,7 @@ jobs: path: test-results test-package-installations: - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 strategy: fail-fast: false matrix: @@ -114,7 +114,7 @@ jobs: - "^14.1.0" # pre 14.1, zip extraction was broken (https://github.com/microsoft/playwright/issues/1988) steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: ${{ matrix.node_version }} - run: npm ci @@ -128,10 +128,10 @@ jobs: fail-fast: false matrix: browser: [chromium, firefox, webkit] - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci @@ -161,10 +161,10 @@ jobs: fail-fast: false matrix: mode: [driver, service] - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci @@ -193,10 +193,10 @@ jobs: fail-fast: false matrix: browser: [chromium, firefox, webkit] - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci @@ -230,7 +230,7 @@ jobs: PW_ANDROID_TESTS: 1 steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 14 - run: npm ci @@ -252,12 +252,10 @@ jobs: chrome_stable_linux: name: "Chrome Stable (Linux)" - strategy: - fail-fast: false - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - name: Install Chrome Stable @@ -292,7 +290,7 @@ jobs: shell: powershell run: Install-WindowsFeature Server-Media-Foundation - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci @@ -316,7 +314,7 @@ jobs: runs-on: macos-10.15 steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci @@ -342,7 +340,7 @@ jobs: shell: powershell run: Install-WindowsFeature Server-Media-Foundation - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: 10 - run: npm ci diff --git a/.github/workflows/trigger_build_chromium.yml b/.github/workflows/trigger_build_chromium.yml index 1d3777ce90..0dc97441af 100644 --- a/.github/workflows/trigger_build_chromium.yml +++ b/.github/workflows/trigger_build_chromium.yml @@ -12,7 +12,7 @@ on: jobs: trigger: name: "trigger" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - run: | curl -X POST \ diff --git a/.github/workflows/trigger_build_deprecated_webkit_mac_10.14.yml b/.github/workflows/trigger_build_deprecated_webkit_mac_10.14.yml index 25e56c3fb2..5be83a97ee 100644 --- a/.github/workflows/trigger_build_deprecated_webkit_mac_10.14.yml +++ b/.github/workflows/trigger_build_deprecated_webkit_mac_10.14.yml @@ -12,7 +12,7 @@ on: jobs: trigger: name: "trigger" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - run: | curl -X POST \ diff --git a/.github/workflows/trigger_build_ffmpeg.yml b/.github/workflows/trigger_build_ffmpeg.yml index 457bd573bb..987b5f935e 100644 --- a/.github/workflows/trigger_build_ffmpeg.yml +++ b/.github/workflows/trigger_build_ffmpeg.yml @@ -12,7 +12,7 @@ on: jobs: trigger: name: "trigger" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - run: | curl -X POST \ diff --git a/.github/workflows/trigger_build_firefox.yml b/.github/workflows/trigger_build_firefox.yml index e1baa4a3f4..bad8806c71 100644 --- a/.github/workflows/trigger_build_firefox.yml +++ b/.github/workflows/trigger_build_firefox.yml @@ -12,7 +12,7 @@ on: jobs: trigger: name: "trigger" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - run: | curl -X POST \ diff --git a/.github/workflows/trigger_build_webkit.yml b/.github/workflows/trigger_build_webkit.yml index 4450aedc10..22e69c0ff8 100644 --- a/.github/workflows/trigger_build_webkit.yml +++ b/.github/workflows/trigger_build_webkit.yml @@ -12,7 +12,7 @@ on: jobs: trigger: name: "trigger" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - run: | curl -X POST \ diff --git a/.github/workflows/trigger_build_winldd.yml b/.github/workflows/trigger_build_winldd.yml index 95de9d2832..4d45987240 100644 --- a/.github/workflows/trigger_build_winldd.yml +++ b/.github/workflows/trigger_build_winldd.yml @@ -12,7 +12,7 @@ on: jobs: trigger: name: "trigger" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - run: | curl -X POST \ diff --git a/.github/workflows/trigger_tests.yml b/.github/workflows/trigger_tests.yml index 2005975747..d130c40550 100644 --- a/.github/workflows/trigger_tests.yml +++ b/.github/workflows/trigger_tests.yml @@ -9,7 +9,7 @@ on: jobs: trigger: name: "trigger" - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - run: | curl -X POST \ diff --git a/docs/src/ci.md b/docs/src/ci.md index cb1c7dd74c..9cffc51215 100644 --- a/docs/src/ci.md +++ b/docs/src/ci.md @@ -119,9 +119,9 @@ For Linux agents, you can use [our Docker container](./docker.md) with Azure Pip ```yml pool: - vmImage: 'ubuntu-18.04' + vmImage: 'ubuntu-20.04' -container: mcr.microsoft.com/playwright:bionic +container: mcr.microsoft.com/playwright:focal steps: ... @@ -189,7 +189,7 @@ Running Playwright on CircleCI requires the following steps: ```yml docker: - - image: mcr.microsoft.com/playwright:bionic + - image: mcr.microsoft.com/playwright:focal environment: NODE_ENV: development # Needed if playwright is in `devDependencies` ``` @@ -211,7 +211,7 @@ to run tests on Jenkins. ```groovy pipeline { - agent { docker { image 'mcr.microsoft.com/playwright:bionic' } } + agent { docker { image 'mcr.microsoft.com/playwright:focal' } } stages { stage('e2e-tests') { steps { @@ -228,7 +228,7 @@ pipeline { Bitbucket Pipelines can use public [Docker images as build environments](https://confluence.atlassian.com/bitbucket/use-docker-images-as-build-environments-792298897.html). To run Playwright tests on Bitbucket, use our public Docker image ([see Dockerfile](./docker.md)). ```yml -image: mcr.microsoft.com/playwright:bionic +image: mcr.microsoft.com/playwright:focal ``` While the Docker image supports sandboxing for Chromium, it does not work in the Bitbucket Pipelines environment. To launch Chromium on Bitbucket Pipelines, use the `chromiumSandbox: false` launch argument. @@ -269,7 +269,7 @@ stages: tests: stage: test - image: mcr.microsoft.com/playwright:bionic + image: mcr.microsoft.com/playwright:focal script: ... ``` diff --git a/docs/src/docker.md b/docs/src/docker.md index 8f13b79d74..e5ed21db69 100644 --- a/docs/src/docker.md +++ b/docs/src/docker.md @@ -16,7 +16,7 @@ This image is published on [Docker Hub](https://hub.docker.com/_/microsoft-playw ### Pull the image ``` -$ docker pull mcr.microsoft.com/playwright:bionic +docker pull mcr.microsoft.com/playwright:focal ``` ### Run the image